search

pop-os / cosmic-comp

Compositor for the COSMIC desktop environment
GNU General Public License v3.0
487 stars 90 forks source link

Request: fullscreen hotkey #646

Open drwankingstein opened 3 months ago

drwankingstein commented 3 months ago

It would be nice to have a dedicated fullscreen hotkey, the usecase for this is separate from from simply maximizing the window. Many applications like chrome or games can often play a lot nicer when properly fullscreened.

As a simple test case; Chrome for instance when you fullscreen it on sway properly hides the title bar and stuff, but does not do so on Cosmic. While chrome isn't a great example app to showcase the usefulness it is good for testing.

Drakulix commented 3 months ago

We intentionally don't have this key as exclusive fullscreen mode is something applications should take themselves and will not behave well with most desktop applications (e.g. it will hide the launcher/app-library/etc). These should be maximized instead.

Chrome however has both a menu toggle and the F11-shortcut to enter proper fullscreen mode (both running with it's wayland backend and it's x11 backend) and that works just fine on cosmic.

Games should also have a fullscreen toggle on their own.

I am however not opposed to have this shortcut in the config file at least, however it would be unbound by default.

drwankingstein commented 3 months ago

That would be appreciated. There are some older wine games that I found essentially require this. Some GDI games specifically. I could also see how some users may want an application to be fullscreen even when they don't natively support it. Off by default is still highly appreciated.

EDIT: Another use for this could be to un-maximise misbehaving applications

BrodieRobertson commented 3 months ago

Is it intended that pressing F11 in COSMIC applications like settings seems to fullscreen them? Or is this just maximize using a binding not listed in the shortcuts?

Quackdoc commented 3 months ago

@BrodieRobertson that is a libcosmic default https://github.com/pop-os/libcosmic/blob/84afe7b50a6cb930cdeb3012afc8a74ae9a49cdf/src/keyboard_nav.rs#L47

bbb651 commented 2 months ago

We intentionally don't have this key as exclusive fullscreen mode is something applications should take themselves and will not behave well with most desktop applications (e.g. it will hide the launcher/app-library/etc). These should be maximized instead.

Hard disagree, browsers are the most used apps everywhere by far and all of them have F11 bound to fullscreen by default, and web apis have the ability to fullscreen very permissively - the majority people are very familiar with the concept of fullscreen, and hiding shell components is not a problem it's a feature. I personally use it the time, from games that don't fullscreen properly to browsers to random other apps. I really think it should be bound to Super + F11 by default, since F11 has such a strong correlation to "toggle fullscreen" that makes a lot of sense, users are very unlikely to press it by mistake and it doesn't conflict with apps that have these toggle fullscreen shortcuts already. I'm not exactly sure what you mean by "exclusive fullscreen", I know it in the context of exclusive and borderless fullscreen modes on windows so I'm assuming it's unrelated.