search

pop-os / cosmic-comp

Compositor for the COSMIC desktop environment
GNU General Public License v3.0
472 stars 86 forks source link

bug: Super + Left Click to move a window in a focused guest libvirt VM instead moves the libvirt window #857

Open RachaelAva1024 opened 2 weeks ago

RachaelAva1024 commented 2 weeks ago

Attempting to move a window inside a Virt-Manager VM with Super + Left Click while the VM is capturing mouse & keyboard inputs will instead move the Virt-Manager VM window and also un-fullscreen the window, but Virt-Manager doesn't realize it's no longer fullscreened.

https://github.com/user-attachments/assets/03d66cea-d4ca-4c00-a7f8-8bb91357f599

(Yes, I have a dedicated VM for playing Minecraft, and I do so to sandbox it for personal security reasons.)

On an unrelated note, many of the graphical elements of COSMIC apps inside of libvirt render as black boxes. Let me know if I should open an issue on that specific bug.

Quackdoc commented 1 week ago

Possibly could be solved with something like https://github.com/pop-os/cosmic-comp/issues/729

Drakulix commented 1 week ago

On an unrelated note, many of the graphical elements of COSMIC apps inside of libvirt render as black boxes. Let me know if I should open an issue on that specific bug.

That is probably caused by the driver used internally, you need hardware acceleration to be enabled and have a proper vulkan driver (not lavapipe). I am not sure how well venus works yet, which seems to be the driver you could get running inside kvm. If you are running venus and this issue persists, feel free to create a separate bug report.

Attempting to move a window inside a Virt-Manager VM with Super + Left Click while the VM is capturing mouse & keyboard inputs will instead move the Virt-Manager VM window and also un-fullscreen the window, but Virt-Manager doesn't realize it's no longer fullscreened.

Hmm, that is an interesting use-case. We probably should treat these shortcuts as inhibited the same way we treat keyboard shortcuts, if a shortcut-inhibitor is active (which should correspond to the grab VirtManager takes).

Drakulix commented 1 week ago

@RachaelAva1024 Can you try this branch on your host and see if that fixes the issue? https://github.com/pop-os/cosmic-comp/pull/869