pop-os / cosmic-dock

Pop!_OS fork of https://github.com/micheleg/dash-to-dock/tree/ubuntu-dock
GNU General Public License v2.0
73 stars 18 forks source link

Please, contribute back upstream #139

Closed 3v1n0 closed 2 years ago

3v1n0 commented 2 years ago

Hey, I've been looking at latest commits of this project, and I think that some of the commits or features I see here could be easily integrated in the upstream dash2dock project too, for example:

Given that this is a quite popular extension and that the people actually working on it are just a few, it would be very appreciated if we could join the efforts as much as we can, keeping our forks for the distro-specific things, but trying to unify the code base the most we can.

jackpot51 commented 2 years ago

Yes, I. interested in pushing these changes upstream

3v1n0 commented 2 years ago

Cool, I'm happy to review them then :)

jackpot51 commented 2 years ago

@13r0ck could you take a look into this?

13r0ck commented 2 years ago

Can do!

13r0ck commented 2 years ago

PR created here

13r0ck commented 2 years ago

https://github.com/micheleg/dash-to-dock/pull/1732 changes have been upstream-ed. Waiting to be merged as of writing this.

edit: [7/7/22] upstream PR has been merged