pop-os / cosmic-epoch

Next generation Cosmic desktop environment
3.09k stars 82 forks source link

Add `text-input-v1` support for non-English text input method #472

Open CarameowCookie opened 3 months ago

CarameowCookie commented 3 months ago

Reference: https://invent.kde.org/plasma/kwin/-/merge_requests/3403

“Main reason to support this old interface is because this is the only protocol chromium (and effectively all electron app) that supports.

The protocol itself very similar to text-input-v2 with some minor difference. So not hard to support by just duplicate some existing code. There might be some unclear protocol design issue if kwin need to support multiple SeatInterface, but for now it should be ok to assume there is only one seat.

Tested using fcitx5 against weston-editor and chromium with flag --enable-features=UseOzonePlatform --ozone-platform=wayland --enable-wayland-ime

Screenshots

weston-editor

weston-editor

vscode

vscode

Drakulix commented 3 months ago

Chromium has added support for text-input-v3: https://issues.chromium.org/issues/40113488#comment88