search

pop-os / cosmic-files

WIP COSMIC file manager
GNU General Public License v3.0
95 stars 71 forks source link

Better support for symlinks #10

Open senntore opened 8 months ago

senntore commented 8 months ago

In current version of cosmic-files, I can open the symlink directories but they've wrong icons & the size details. Here is a screenshot in cosmic-files & nautilus: image

senntore commented 1 month ago

Currently the search results are also not showing files & directories that are inside symlink. So, if we were to search in home directory(from the above screenshots), for a file that is inside one of the symlink, then the search results should be showing those files. but it is not showing them right now. Gnome's File manager does show results for them, so maybe it's worth adding the feature to Cosmic files as well.

zsilet commented 3 weeks ago

A couple of additional notes (as of Alpha1 8-10 commit ba0adf6):

  1. Clicking a symlinked directory launches a new instance of COSMIC files (should just follow the link)
  2. (Not sure if related) In VSCode, when attempting to open a project from a folder, when I get to a symlink, there is no way to 'follow' it. Clicking the link automatically opens that folder as the project folder. I did verify that this is NOT the behavior on 'classic' pop-os (linked directories are shown with a directory icon, and are followed properly in VScode).
zsilet commented 3 weeks ago

I am seeing an improvement in symlinks handling within COSMIC files as of the latest update: 1) Symlinked directories show up with the associated Directory icon 2) Clicking the link opens the directory without launching a new instance of COSMIC files. Thanks for the updates!

Some additional issues/improvements would still be welcome: 1) It would be nice to have a small link icon overlayed in the corner of a linked directory. 2) (Not sure if related) VSCode still does not follow links via Open Folder, and links show as binary files.

I am not sure if this is re

jackpot51 commented 3 weeks ago

2 may be fixed by https://github.com/pop-os/xdg-desktop-portal-cosmic/commit/edca092cfba65d2b8952491ed74d5d673ee700dd, which updates the cosmic-files embedded there.

zsilet commented 3 weeks ago

Thanks, will keep an eye on it.

zsilet commented 2 weeks ago

Verified that my issue 2 is now fixed (Symlinked directories show as directories, and are followed, in VScode's open folder dialog). Thanks!