pop-os / cosmic-files

WIP COSMIC file manager
GNU General Public License v3.0
109 stars 82 forks source link

Clicking Search in the Upload Dialog Crashes the Window #601

Open WatchMkr opened 1 week ago

l-const commented 1 week ago

Reproduced, here are some logs:

fe cosmic-session[15804]: thread 'main' panicked at /builddir/build/BUILD/xdg-desktop-portal-cosmic-7c8313898bffce9e44e0549782316c57597216d1/vendor/cosmic-files/src/tab.rs:2600:52:
 fe cosmic-session[15804]: Cannot block the current thread from within a runtime. This happens because a function attempted to block the current thread while the thread is being used to drive asynchronous tasks.
fe /usr/libexec/gdm-wayland-session[15804]: 2024-10-15T21:13:12.876214Z  WARN 

xdg-desktop-portal-cosmic: cosmic_session: thread 'main' panicked
 at /builddir/build/BUILD/
xdg-desktop-portal-cosmic-7c8313898bffce9e44e0549782316c57597216d1/vendor/cosmic-files/src/tab.rs:2600:52:

 fe /usr/libexec/gdm-wayland-session[15804]: 2024-10-15T21:13:12.876779Z  WARN xdg-desktop-portal-cosmic: 

cosmic_session: Cannot block the current thread from within a runtime. 

This happens because a function attempted to block the current thread while the thread is being used to drive asynchronous tasks.

 fe /usr/libexec/gdm-wayland-session[15804]: 2024-10-15T21:13:12.876797Z  WARN xdg-desktop-portal-cosmic: cosmic_session: note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
fe /usr/libexec/gdm-wayland-session[15804]: 2024-10-15T21:13:12.881613Z ERROR launch_pad: process ' WAYLAND_DISPLAY=wayland-1 DISPLAY=:0 XDG_SESSION_TYPE=wayland WAYLAND_SOCKET=73 PORTAL_WAYLAND_SOCKET=70 /usr/libexec/xdg-desktop-portal-cosmic ' failed with code 101
fe /usr/libexec/gdm-wayland-session[15804]: 2024-10-15T21:13:12.881641Z ERROR cosmic_session: /usr/libexec/xdg-desktop-portal-cosmic exited with error 101 fe /usr/libexec/gdm-wayland-session[15804]: 2024-10-15T21:13:12.881723Z  INFO launch_pad: draining stdin receiver before restarting process
 fe /usr/libexec/gdm-wayland-session[15804]: 2024-10-15T21:13:12.881754Z  INFO launch_pad: sleeping for 6ms before restarting process /usr/libexec/xdg-desktop-portal-cosmic (restart 0)
 fe /usr/libexec/gdm-wayland-session[15804]: 2024-10-15T21:13:12.883530Z  INFO cosmic_session::comp: sending 2 fds
 fe cosmic-session[15804]: note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
 fe /usr/libexec/gdm-wayland-session[15804]: 2024-10-15T21:13:12.889823Z  INFO launch_pad: restarted process ' WAYLAND_DISPLAY=wayland-1 DISPLAY=:0 XDG_SESSION_TYPE=wayland WAYLAND_SOCKET=44 PORTAL_WAYLAND_SOCKET=56 /usr/libexec/xdg-desktop-portal-cosmic ', now at 1 restarts
 fe xdg-desktop-por[16316]: Backend call failed: Remote peer disconnected
 fe cosmic-session[15804]: process ' WAYLAND_DISPLAY=wayland-1 DISPLAY=:0 XDG_SESSION_TYPE=wayland WAYLAND_SOCKET=73 PORTAL_WAYLAND_SOCKET=70 /usr/libexec/xdg-desktop-portal-cosmic ' failed with code 101
 fe cosmic-session[15804]: /usr/libexec/xdg-desktop-portal-cosmic exited with error 101

Commit version: https://github.com/pop-os/cosmic-files/commit/583d3dfa

I think the https://docs.rs/tokio/latest/tokio/sync/mpsc/struct.Receiver.html#method.blocking_recv for search_results caused this.