search

pop-os / cosmic-panel

WIP
GNU General Public License v3.0
109 stars 21 forks source link

Center segment goes left when panel is extended #129

Closed git-f0x closed 6 months ago

git-f0x commented 6 months ago

Caused by #128. The uneven padding on the left side is fixed, but the center segment now behaves like the start segment if the start segment is empty. The uneven padding (from an empty end segment) on the right is still there.

Also a top-anchored panel goes mostly off screen when Gap between panel and screen edges is enabled (or isn't drawn properly since when autohide is enabled it shows the same thin bottom part of the panel when the mouse is at the screen edge). Disabling Extend panel to screen edges makes the top-anchored panel not show up.

Edit: Probably unrelated

The panel on the left and right edge also seems to not be drawn properly when there's a non-extended non-autohiding dock that might intersect when maximized (though this might not be related to that PR). screenshot-2024-03-16-20-59-25 This might have been there before. Not sure how that would be best handled to not have the panel cut off when not maximized. Maybe by mimicking part of the behavior when the panel is placed intersecting with an autohiding non-extended dock, then disabling autohide for that dock and then maximizing (i.e. the panel resizes to accommodate the extended dock, and extends back when the dock retracts(this second part doesn't happen at the moment)).

wash2 commented 6 months ago

Ahh ok sorry. I did test this but I guess I missed these issues. I'll take a look

git-f0x commented 6 months ago

It's nothing urgent. Have a great weekend!

wash2 commented 6 months ago

131 should fix the issue you found with the side panel after maximization. I've undone the commit which removed the gap from the left of the center applets in the dock, but I will revisit that when I get a chance. It should also fix lots of issues I noticed with scaling :)

git-f0x commented 6 months ago

Just to note, the gap is present wherever there's an empty segment (e.g. on the right if the end segment is empty, a double width gap on the right if an applet is in the start segment and the other segments are empty, etc...) and also affects the panel (not just the dock). The minimize applet also leaves a large gap when empty, so best to avoid it when testing. Anyways, thank you for the fix!