search

pop-os / cosmic-panel

WIP
GNU General Public License v3.0
106 stars 19 forks source link

autohide panel shakes a little when opening #149

Open ryanabx opened 4 months ago

ryanabx commented 4 months ago

https://github.com/pop-os/cosmic-panel/assets/56272643/a47a20e1-fb5f-4904-a36a-8b3aa09476ec

git-f0x commented 4 months ago

On my end, it happens when continuing to move the cursor against the screen edge while the panel is revealing itself (just quickly moving the cursor there and not moving it doesn't produce a shake).

wash2 commented 3 months ago

I think this is possibly not a panel issue. My assumption is that the pointer leaves the panel when continuously moved against the edge. I'll test to see if creating a slightly larger input region than the size of the panel fixes it though.

ryanabx commented 3 months ago

Thanks so much for looking into it! I agree with your assumption, that's what it seems like its doing

git-f0x commented 2 months ago

While I'm not sure, this commit might be related pop-os/cosmic-comp@929f4fc, since the panels don't shake on the left or top edges. Other issues also report mouse input not being registered along the bottom and right edges.

ryanabx commented 2 months ago

While I'm not sure, this commit might be related pop-os/cosmic-comp@929f4fc, since the panels don't shake on the left or top edges. Other issues also also report mouse input not being registered along the bottom and right edges.

This was a problem before that commit btw

wash2 commented 2 months ago

Just following up on this, I don't think I can fix the issue with the input region.

git-f0x commented 2 months ago

It seems likely that this is a comp issue. Unrelated issue, but can also cause a shake: When e.g. an extended non-autohiding floating panel is anchored to top, and a floating autohiding dock is also anchored to top, the dock reveals only when the cursor is near the side of the panel away from the screen edge. Continuing to move the cursor towards the screen edge makes the dock hide again. While an unlikely setup, the dock should probably stay revealed when the cursor is at the screen edge).

murilomentor commented 2 weeks ago

I was testing this today and when some libcosmic apps are maximized and I try to reproduce this by moving the cursor to the bottom edge of the screen, the cursor changes to to the resize cursor, like when we hover the cursor above the bottom of a window. That made me think if there's any gap between the dock and the edge of the screen, so I tried to click to see if the window that was maximized and was behind another window would receive focus, and it does. So the gap hypothesis may be true.

https://github.com/user-attachments/assets/9541e033-fd7c-47a5-813f-8f633edb2b9e