pop-os / cosmic-panel

WIP
GNU General Public License v3.0
105 stars 19 forks source link

fix: preserve non-maximized config for autohide panels/docks #157

Closed ryanabx closed 3 months ago

ryanabx commented 3 months ago

This PR fixes the behavior of autohide panels/docks when a maximized window is focused.

Previously, the panel/dock would expand itself to the edges, regardless of whether the setting is turned off in the settings. While this is appropriate for regular panels, autohide panels/docks should not expand to edges unless it's set that way in settings.

https://github.com/pop-os/cosmic-panel/assets/56272643/0d47bdaa-59ae-4c6f-8c6a-b8342fc2218e

wash2 commented 3 months ago

Thanks, I believe the original design is that the dock and panel both extend when a window is maximized, so I think this needs approval from @pop-os/ux, unless it was already approved in a thread on mattermost

ryanabx commented 3 months ago

It was not pre-approved, so we will wait and see what UX thinks!

From my subjective view, the dock shouldn't automatically extend if it's an autohide dock. I believe it matches behavior on other systems with floating autohide docks

Edit: clearer wording

maria-komarova commented 3 months ago

We may have missed that particular case in the original design so I'm fine with the suggested changes to not extend the dock or panel that are set to autohide.