pop-os / cosmic-panel

WIP
GNU General Public License v3.0
105 stars 19 forks source link

Panic when switching theme #186

Closed git-f0x closed 1 month ago

git-f0x commented 2 months ago

While testing #185, the system was in dark theme and the panel was in light theme. When I at one point clicked the Match desktop option for panel appearance, the desktop froze (trying to switch to a different tty didn't work), so I did a REISUB. Can't get it to reproduce again, so not sure what circumstances triggered it.

May 27 14:17:13 pop-os cosmic-panel[1523]: thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: Os { code: 24, kind: Uncategorized, message: "Too many open files" }': /build/cosmic-panel-mREyfv/cosmic-panel-0.1.0~1715952984~22.04~5cac910/vendor/xdg-shell-wrapper/src/util.rs:35
                                              0: <unknown>
                                              1: <unknown>
                                              2: <unknown>
                                              3: <unknown>
                                              4: <unknown>
                                              5: <unknown>
                                              6: <unknown>
                                              7: <unknown>
                                              8: <unknown>
                                              9: <unknown>
                                             10: <unknown>
                                             11: <unknown>
                                             12: <unknown>
                                             13: <unknown>
                                             14: <unknown>
                                             15: <unknown>
                                             16: <unknown>
                                             17: <unknown>
                                             18: <unknown>
                                             19: <unknown>
                                             20: <unknown>
                                             21: <unknown>
                                             22: <unknown>
                                             23: <unknown>
                                             24: <unknown>
                                             25: <unknown>
                                             26: <unknown>
May 27 14:17:14 pop-os cosmic-panel[21819]: Failed to connect to the notifications daemon Err(Elapsed(()))
wash2 commented 2 months ago

This is most likely due to too many applications watching the config files instead of using the cosmic settings daemon dbus interface. I'll try looking more into this to see if any of the cosmic shell apps are watching a bunch of files. A fix specifically for the panel would be to prefer the dbus interface for config changes.

git-f0x commented 1 month ago

Should I close this, since it hasn't happened to me since?

leviport commented 1 month ago

Yeah that's probably best. It can always be reopened later if it comes back.