Closed wash2 closed 3 weeks ago
Moving xdg-shell-wrapper
into the same repository seems good (I'd personally be inclined to just a have a single cosmic repository if everyone didn't run screaming at the word "monorepository"). Though I'd prefer to merge repositories in a way that preserves history (have a commit moving xdg-shell-wrapper into a subdirectory, then merge the unrelated git histories).
Though it doesn't really matter that much, ultimately. Since we can still have the history of xdg-shell-wrapper
as an archived repository.
Though I'd prefer to merge repositories in a way that preserves history (have a commit moving xdg-shell-wrapper into a subdirectory, then merge the unrelated git histories).
YES PLEASE. This is a side story, but at my work, there's a repo that got migrated and history wasn't preserved. And someone made a patch in the old repo that needed to be adapted to the new repo, and I literally had to manually copy paste parts of the code instead of having the option to 3-way merge.
As of 9b87ef5 it looks like this also closes https://github.com/pop-os/cosmic-panel/issues/210
From some initial testing, it seems that applets on floating panels go outside panel bounds. The inner edge of the panel seems to stay at the same place, and the panel just shrinks when going into floating from unfloated (e.g. when un-maximizing). Also visible on the App Tray highlight behind cosmic-term
in the screenshot above.
Edit: while not very important, the minimize animation for apps inside the App Tray overflow is slightly weird.
From some initial testing, it seems that applets on floating panels go outside panel bounds. The inner edge of the panel seems to stay at the same place, and the panel just shrinks when going into floating from unfloated (e.g. when un-maximizing). Also visible on the App Tray highlight behind
cosmic-term
in the screenshot above.Edit: while not very important, the minimize animation for apps inside the App Tray overflow is slightly weird.
That might be an issue after the latest commit switching how the background is drawn. Thanks for catching that
So, as mentioned earlier, do we want to rebase this in a way that preserves the history (and ideally commit hashes) of xdg-shell-wrapper?
applets on floating panels go outside panel bounds
Fixed at PanelAnchor Top and Bottom, still present at Left and Right.
So, as mentioned earlier, do we want to rebase this in a way that preserves the history (and ideally commit hashes) of xdg-shell-wrapper?
I don't know if it is really worth the trouble to keep the history of xdg-shell-wrapper here because it is archived. I also plan on refactoring the panel after alpha 1 release so that it doesn't really use xdg-shell-wrapper anymore.
This adds overflow menus to each section of the panel when it runs out of space. There are still a couple issues related to scaling, but it should be otherwise ok to test with.