pop-os / cosmic-panel

WIP
GNU General Public License v3.0
113 stars 26 forks source link

[Bug/Crash] - Changing the panel settings too many times leads to crash #244

Open peterkrull opened 2 months ago

peterkrull commented 2 months ago

To reproduce, change a setting relating to the panel (like its opacity) continually, until it crashes. It is also possible to flip the toggle switches to crash it.

I have built with this commit.

https://github.com/user-attachments/assets/f1a9491b-432c-4d14-a0ee-062edb0c4b75

with the following journalctl entry:

Aug 13 18:35:41 fedora cosmic-panel[51209]: thread 'main' panicked at 'Out of file descriptors: IoError(Os { code: 24, kind: Uncategorized, message: "Too many open files" })': cosmic-panel-bin/src/iced/mod.rs:267
wash2 commented 2 months ago

Which commit have you built the panel with? https://github.com/pop-os/cosmic-panel/commit/e184d10535e43dfc3e470a481f81f9fe24359521?

peterkrull commented 2 months ago

Yes that is the commit I am on

wash2 commented 2 months ago

Ok, I've managed to recreated the issue on this commit. I'll work on a fix for this soon :+1:

peterkrull commented 2 months ago

Fantastic, thank you! 🤙