search

pop-os / cosmic-protocols

Addtional wayland-protocols used by the COSMIC desktop environment
27 stars 6 forks source link

feat: add focused as a toplevel state #25

Closed ryanabx closed 5 months ago

ryanabx commented 5 months ago

This PR adds a focused state to cosmic-toplevel-info-unstable

This addition would be necessary for the visual app-list focus hint (https://github.com/pop-os/cosmic-applets/pull/328) and will also be required for click-to-minimize focused windows on the app-list (currently the system tries to track active toplevels per workspace but is not very robust)

The addition would require there to be reporting of focused toplevels in cosmic-comp, which I'm not super confident that I could do on my own.

@Drakulix questions for you, do I need to bump the version of cosmic-toplevel-info-unstable? And at some point would you be able to either give me guidance on or implement the tracking of this state in cosmic-comp?

Consolatis commented 5 months ago

I think basically all compositors and panels using wlr-foreign-toplevel treat active to mean focused and thus also use it to implement activate-or-minimize behavior. Not quite sure what active could mean other than focus, why does cosmic allow multiple windows to be active at the same time?

ryanabx commented 5 months ago

I think basically all compositors and panels using wlr-foreign-toplevel treat active to mean focused and thus also use it to implement activate-or-minimize behavior. Not quite sure what active could mean other than focus, why does cosmic allow multiple windows to be active at the same time?

In cosmic, workspaces all have one active window. Not sure how other compositors do it.

Currently there's also a bug with some apps on cosmic where state changes will be forever reported as pending, but the activated state within the window will be changed

ryanabx commented 5 months ago

No longer needed as there is a workaround to the activated state bug