pop-os / cosmic-session

Session manager for the COSMIC desktop environment
GNU General Public License v3.0
68 stars 18 forks source link

fix: allow calls for systemd graphical target to fail #34

Closed jokeyrhyme closed 8 months ago

jokeyrhyme commented 8 months ago

in all testing below, the session and compositor continue to launch as normal:

jokeyrhyme commented 8 months ago

Another thought I had is that we could detect systemd the same way cosmic-comp does (using the libsystemd crate), and then change the behaviour of this PR (or in a follow-up PR) to not even attempt to call systemctl if systemd is not running

That would keep logs cleaner on non-systemd systems

Drakulix commented 8 months ago

Another thought I had is that we could detect systemd the same way cosmic-comp does (using the libsystemd crate), and then change the behaviour of this PR (or in a follow-up PR) to not even attempt to call systemctl if systemd is not running

That would keep logs cleaner on non-systemd systems

It might, but we would pull another dbus api, which we don't really need. It think this is fine.