search

pop-os / cosmic-settings-daemon

GNU General Public License v3.0
20 stars 16 forks source link

locale: Fix syncing cycle #37

Closed Drakulix closed 1 month ago

Drakulix commented 1 month ago

A quick and easy way to avoid cycling between cosmic-conf and localed for synchronization.

ids1024 commented 1 month ago

A simple enough solution that looks reasonable, and seems to work.

I'm still not sure if the way we're syncing with the system locale will cause problems (non admin users aren't supposed to be able to set the system locale, right? how does this work with multiple accounts?). But it's good to at least address this immediate issue.

Drakulix commented 1 month ago

A simple enough solution that looks reasonable, and seems to work.

I'm still not sure if the way we're syncing with the system locale will cause problems (non admin users aren't supposed to be able to set the system locale, right? how does this work with multiple accounts?). But it's good to at least address this immediate issue.

Note that this is not changing the locale! We just sync keyboard layouts. The goal is for e.g. login managers or installers to be able to set the keyboard layout and carry that over into the user-session via a well-defined api.

ids1024 commented 1 month ago

Oh yeah, keyboard layout rather than the locale.

But if a user has configured custom keyboard layouts, that differ from the system setting, they'll be overwritten at login. Right? And such.

Drakulix commented 1 month ago

But if a user has configured custom keyboard layouts, that differ from the system setting, they'll be overwritten at login. Right? And such.

Yes, at least if they set this up before cosmic-settings-daemon started syncing or in multi-user scenarios. The latter is definitely not the best experience. We might want to have a "follow system" vs "user-override" option in the settings at some point.