pop-os / cosmic-settings

COSMIC Settings
GNU General Public License v3.0
134 stars 61 forks source link

support keyboard shortcuts which are not ascii #398

Open leb-kuchen opened 4 days ago

leb-kuchen commented 4 days ago

Cosmic settings changes super+ä to Super+Adiaeresis.

   (
        modifiers: [
            Super,
            Shift,
        ],
        key: "m",
    ): Minimize,
    (
        modifiers: [
            Super,
        ],
        key: "Adiaeresis",
    ): Minimize,

Super+Shift+M works, while Super+Ä does not.

Drakulix commented 3 days ago

Try to change it to adiaeresis. Adiaeresis is the uppercase variant, which shouldn't match.

leb-kuchen commented 3 days ago

This works. I think cosmic-settings-deamon shouldn't use to_ascii_lowercase. Feel free to move the issue.