pop-os / cosmic-settings

COSMIC Settings
GNU General Public License v3.0
165 stars 106 forks source link

RFE: Build-time configured distro logo in system about page #753

Open Conan-Kudo opened 1 day ago

Conan-Kudo commented 1 day ago

I would like to have the Fedora logo prominently shown in the COSMIC Settings About System page. Currently, no such logo is present:

COSMIC About System page

In contrast to KDE Plasma:

KInfoCenter About System page

And GNOME:

GNOME Control Center About page

Could we get some kind of similar build-time configuration knob like what GNOME Control Center has to show this?

For example, this is what we have in Fedora's gnome-control-center package:

%meson \
  -Ddocumentation=true \
  -Dlocation-services=enabled \
%if 0%{?fedora}
  -Ddistributor_logo=%{_datadir}/pixmaps/fedora_logo_med.png \
  -Ddark_mode_distributor_logo=%{_datadir}/pixmaps/fedora_whitelogo_med.png \
%endif
%if 0%{?rhel}
  -Ddistributor_logo=%{_datadir}/pixmaps/fedora-logo.png \
  -Ddark_mode_distributor_logo=%{_datadir}/pixmaps/system-logo-white.png \
%endif
%if %{with malcontent}
  -Dmalcontent=true \
%else
  -Dmalcontent=false \
%endif
  %{nil}
l-const commented 1 day ago

gnome-control-center in setup_os_logo() https://github.com/pop-os/gnome-control-center/blob/168857aeef9b3526ed120404c7eca59cedb7cff6/panels/info-overview/cc-info-overview-panel.c#L936 , uses g_get_os_logo from glib here https://github.com/GNOME/glib/blob/main/glib/gutils.c#L1675-L1683 : that reads /etc/os-release LOGO var

Conan-Kudo commented 1 day ago

Yes, though that's not necessarily the best logo icon to use, which is why we override and set it explicitly in gnome-control-center.

git-f0x commented 23 hours ago

This was present previously, but was removed a while back: https://github.com/pop-os/cosmic-settings/pull/149 87371069f7b88a3a51139aa486ae9a8acf5722aa.

Conan-Kudo commented 23 hours ago

I'm not sure what defines distributor-logo, but it doesn't exist in Fedora as far as I know. It being non-portable might have been a reason for its removal previously.

l-const commented 23 hours ago

I see git patches here: https://github.com/pop-os/gnome-control-center/blob/168857aeef9b3526ed120404c7eca59cedb7cff6/debian/patches/ubuntu/distro-logo.patch#L32

git-f0x commented 23 hours ago

As far as I know, that just searches for an icon with that name in the standard places. So if there's a Fedora logo icon named distributor-logo.svg in /usr/share/icons/..., that that would be displayed.