search

pop-os / desktop-widget

Pop Desktop Settings Widget
GNU Lesser General Public License v3.0
43 stars 34 forks source link

Various updates #15

Closed ids1024 closed 3 years ago

ids1024 commented 3 years ago

Further explanation of each change in commit messages.

ids1024 commented 3 years ago

Added a commit make the workspace switcher side setting work, using https://github.com/pop-os/cosmic/pull/77.

jacobgkau commented 3 years ago

The option for the hot corner is currently labeled Enable top-left hot corner. Should the option mention Workspaces since that's what the hot corner will open? (In the default layout, the Workspaces button is in the top-left, but if I disable the Workspaces button, then I have an Applications button in the top-left and the hot corner still opens Workspaces-- I'm just thinking that with the current wording, it might not be intuitive for someone to know the hot corner can't be configured further in a situation like that.)

This also seems to remove the entire Placement of the Workspace Picker section. I see that you only removed two of the options, but it's no longer showing up at all:

Screenshot from 2021-06-18 13-45-32

We still want left/right as options, right?

ids1024 commented 3 years ago

The option for the hot corner is currently labeled Enable top-left hot corner. Should the option mention Workspaces since that's what the hot corner will open?

I wasn't sure about the best wording for that. "Enable top-left workspaces hot corner"? Hm...

This also seems to remove the entire Placement of the Workspace Picker section. I see that you only removed two of the options, but it's no longer showing up at all:

The section only shows up if it finds the relevant gsettings key, which requires https://github.com/pop-os/cosmic/pull/77. If you install that branch it should show up and work.

jacobgkau commented 3 years ago

The section only shows up if it finds the relevant gsettings key, which requires pop-os/cosmic#77. If you install that branch it should show up and work.

Got it, that's working fine.

I wasn't sure about the best wording for that. "Enable top-left workspaces hot corner"? Hm...

I was thinking Enable top-left hot corner for Workspaces, keeping the "hot corner" term generic but just making clear that it can only be used for Workspaces at this time. Might not hurt to confirm with @maria-komarova or others, whether a change is needed at all and what it should be.

maria-komarova commented 3 years ago

For the hot corner, I guess the option with the hot corner being disabled is still the default, right? So could we just omit Applications row and have the following section under Desktop > General? Or am I missing some context? image

jackpot51 commented 3 years ago

Yes, @maria-komarova, that would still be possible.

maria-komarova commented 3 years ago

Sorry, missed that we were trying to make it a toggle. Wonder if bullet points could be more clear since we plan to add Applications eventually.

ids1024 commented 3 years ago

Currently in this branch it looks like this (with the wording @jacobgkau suggested).

Screenshot from 2021-06-18 09-51-33

Wonder if bullet points could be more clear since we plan to add Applications eventually.

Seems a bit strange to have radio buttons for something that's just enabled or disabled. It could be changed to radio buttons later when more options are added.

maria-komarova commented 3 years ago

Sounds good. Yes, you are right, toggle seems better. I wonder if we should put it under Workspaces for now instead of General since it is only for Workspaces. Would the following copy work a bit better? "Open Workspaces using Top-left Hot Corner"

WatchMkr commented 3 years ago

Looking forward, General is probably better when we add Applications and different functionality per corner.

WatchMkr commented 3 years ago

Allow setting autohide or intellihide for dock (or showing it all the time)

I'd like to change our current description to intellihide and perhaps leave out autohide.

This bug causes problems with intelihide that I think would alleviate the need for autohide: https://github.com/pop-os/gnome-shell-extension-ubuntu-dock/issues/8

maria-komarova commented 3 years ago

Sounds good. I believe if we figure out a fix for this bug, the behavior would be improved significantly.

ids1024 commented 3 years ago

I think some people will still want to just set it to autohide. Does leaving it out as an option really make things much simpler?

WatchMkr commented 3 years ago

I think it's more about clarity. What does autohide provide that inteilihide doesn't? And if there's an additional similar feature, can we describe the differences so there's little hesitation about which one the user wants?

jacobgkau commented 3 years ago

The three options listed in this comment seem to describe the differences well, and can be summarized succinctly:

Instead of a drop-down, maybe this would work better as a bullet-point list so the descriptions can be included? (With "never" being the first/default option in the list.)

Upstream Dash to Dock seems to have separate on/off settings for Autohide and Intellihide, and has an additional checkbox setting for "application based intellihide": https://micheleg.github.io/dash-to-dock/media/settings1.png

That upstream panel looks too confusing, but if the features are present anyway (which it looks like they are), being able to configure seems better than not being able to configure, especially for getting former Dash to Dock users comfortable using the built-in fork. The "active window only" mode seems the most useless of the three to me, but I could see someone wanting the dock to always hide for aesthetic purposes.

jacobgkau commented 3 years ago

Maybe these wordings would work better for bullet points. Hide dock:

And that's in order of "least hidden" to "most hidden." Just an idea.

maria-komarova commented 3 years ago

The Active window only seems to be what we currently have - seems to fit with the bug @WatchMkr mentioned above. That behavior was found to be frustrating during the diary study we did. So I would argue against including it. Auto-hide could potentially be a desired behavior but if intellihide is done right (behind any window) then the only difference is if someone wants to see the empty display without a dock on it. Are there many use cases when this is useful?

WatchMkr commented 3 years ago

I like where you're going. Application based is a weird one though. It conflicts with tiling layouts and probably isn't useful enough to include. I'm hoping that's what we have set and we don't actually have a Dash to Dock bug to hunt down.

How about:

Dock Visibility Always visible Always hide: Dock always hides unless actively being revealed by the mouse. Intelligently hide: Dock hides when any window overlaps the dock area.

maria-komarova commented 3 years ago

Sounds good.

ids1024 commented 3 years ago

Updated to use radio buttons:

Screenshot from 2021-06-18 15-10-03

Also added a commit implementing the "Show * Icon in Dock" settings. With that, everything here should now be implemented.