search

pop-os / desktop-widget

Pop Desktop Settings Widget
GNU Lesser General Public License v3.0
43 stars 34 forks source link

Integrating GNOME Initial Setup pages #19

Closed mmstick closed 3 years ago

maria-komarova commented 3 years ago

I was mulling over this wording trying to make it shorter but maybe we should opt for consistency and keep it exactly the same as on the Desktop panel. I'm not entirely sure.

maria-komarova commented 3 years ago

@mmstick looking at this merge request, are we ready for the visual assets to be added to the Launcher and Gestures pages in the Initial setup? At minimum we could use illustrations but I was originally thinking about using animations in the form of video files. Let me know where we are with it and I'll provide the assets.

jacobgkau commented 3 years ago

I was mulling over this wording trying to make it shorter but maybe we should opt for consistency and keep it exactly the same as on the Desktop panel.

I'm not sure that would work, only because the Desktop panel currently has an Enable Dock setting and a separate setting for Extend dock to the edges of the screen, while the GIS page/mockup has one setting with three options. Unless you just mean changing GIS to Extend dock to the edges of the screen and Don't extend dock to the edges of the screen.

Like I said, the shortened version just reads more naturally without the, which is probably why @mmstick deviated from the mockup. to the edges is ambiguous without of the screen after it; it should either be just to edges for a terse phrase, or to the edges of the screen for a fuller phrase.

@mmstick looking at this merge request, are we ready for the visual assets to be added to the Launcher and Gestures pages in the Initial setup?

It looks like Michael's already added the static pages that don't control any settings to https://github.com/pop-os/gnome-initial-setup/pull/70, although I haven't gotten a chance to look at it since it won't build until this PR is merged.

maria-komarova commented 3 years ago

Yes, I merely meant the copy. I'm fine with keeping it "Dock extends to edges" and "Dock doesn't extend to edges".