pop-os / desktop-widget

Pop Desktop Settings Widget
GNU Lesser General Public License v3.0
43 stars 35 forks source link

Behaviour to handle when the user disables super key behaviour in COSMIC #55

Closed jmaargh closed 3 years ago

jmaargh commented 3 years ago

Following discussion and design from https://github.com/pop-os/cosmic/pull/183

image

jacobgkau commented 3 years ago

Failed to build on the build server with this message:

cargo build --release --frozen
error: failed to get `glib` as a dependency of package `ffi v0.1.2 (/<<PKGBUILDDIR>>/ffi)`

Caused by:
  attempting to make an HTTP request, but --frozen was specified

I don't think this is related to the changes being made, we probably need a fix like this or this for desktop-widget. I'm assuming the first one is better.

ids1024 commented 3 years ago

Currently the code here crashes if the installed version of Cosmic doesn't have the gsettings key. It's probably better to add a test against settings.get_property_settings_schema().map_or(false, |x| x.has_key("disable-overlay-key")) (like some other existing code) to disable this logic when the gsettings key isn't found.

jmaargh commented 3 years ago

@ids1024 nice catch, fixed

jacobgkau commented 3 years ago

This increases the minimum width of the widgets on the Desktop -> General settings page, only when the override has been disabled. This doesn't change the width that libhandy collapses the columns, but instead adds horizontal scrolling on the page when it's too small:

Screenshot from 2021-08-12 12-58-07

It would be better if the text wrapped so this didn't happen. Would it be feasible to make the label text wrap? Aside from that nitpick, testing is looking great on this.

jacobgkau commented 3 years ago

I figured out the text wrapping and pushed a commit to fix that.

Screenshot from 2021-08-12 13-12-11