Closed jmaargh closed 3 years ago
Failed to build on the build server with this message:
cargo build --release --frozen
error: failed to get `glib` as a dependency of package `ffi v0.1.2 (/<<PKGBUILDDIR>>/ffi)`
Caused by:
attempting to make an HTTP request, but --frozen was specified
I don't think this is related to the changes being made, we probably need a fix like this or this for desktop-widget. I'm assuming the first one is better.
Currently the code here crashes if the installed version of Cosmic doesn't have the gsettings key. It's probably better to add a test against settings.get_property_settings_schema().map_or(false, |x| x.has_key("disable-overlay-key"))
(like some other existing code) to disable this logic when the gsettings key isn't found.
@ids1024 nice catch, fixed
This increases the minimum width of the widgets on the Desktop -> General settings page, only when the override has been disabled. This doesn't change the width that libhandy collapses the columns, but instead adds horizontal scrolling on the page when it's too small:
It would be better if the text wrapped so this didn't happen. Would it be feasible to make the label text wrap? Aside from that nitpick, testing is looking great on this.
I figured out the text wrapping and pushed a commit to fix that.
Following discussion and design from https://github.com/pop-os/cosmic/pull/183