Empty sensors fix - Githubissues

pop-os / desktop-widget

Pop Desktop Settings Widget

GNU Lesser General Public License v3.0

43 stars 34 forks source link

Empty sensors fix #84

Closed ahoneybun closed 2 years ago

ahoneybun commented 2 years ago

Currently the logs will create an empty sensors file on non-System76 hardware. This is because the system76-driver pulls in lm-sensors. This PR does the following:

Adds the lm-sensor dep
Reorders the build-depends to match Debian standard
Updates the d/compat level to 10 to fix build warnings
Updates the d/changelog to 0.2.1

ahoneybun commented 2 years ago

It looks like the latest change does install the lm-sensors package though the sensors file is still empty.

ahoneybun commented 2 years ago

Using gnome-control-center supportthen creating logs doesn't seem to log anything other then the logs being created.

UPDATE: It's because I was testing in a VM. Simcha is testing on real hardware for me.

ahoneybun commented 2 years ago

Alright so lm-sensors was installed and the sensor file has data now.

jacobgkau commented 2 years ago

I'm confused what this has to do with desktop-widget. Would it make more sense for support-panel to depend on lm-sensors instead of desktop-widget?

ahoneybun commented 2 years ago

Now that I know that exists I believe I agree with you @jacobgkau . I'll make a new PR there in a bit.

XV-02 commented 2 years ago

Action plan is to pursue this through another repo. Closing for housekeeping/organization purposes.