search

pop-os / desktop

Desktop metapackage
Other
27 stars 9 forks source link

fix: Remove appmenu gtk modules #104

Closed mmstick closed 1 year ago

mmstick commented 1 year ago

Fixes https://github.com/HandBrake/HandBrake/issues/4762

mmstick commented 1 year ago

Do check if this is still an issue with this removed: 5ef8d193bad6fbb805d2945a414237d9e4bf38a2. We did stop offering the global appmenu in GNOME with the cosmic extensions, so it's probably fine to remove it now.

jacobgkau commented 1 year ago

On lemp10, when starting HandBrake (from the Ubuntu repository) in Wayland, I was crashing with a segmentation fault when appmenu-gtk3-module was installed. After removing appmenu-gtk3-module, HandBrake opens successfully in Wayland, although starting it from the terminal shows Gtk-Message: Failed to load module "appmenu-gtk-module". I observed the same thing on oryp8.

The HandBrake 1.6.0 flatpak opens whether the appmenu-gtk3-module package is installed or not, and does not show duplicated menus even if the module is installed.

After building HandBrake 1.6.0 from source, I was able to recreate the duplicate menu entries with appmenu-gtk3-module installed, and no duplicates (but still getting Failed to load module "appmenu-gtk-module") with the module uninstalled.

I'm still trying to find if there are any actual adverse effects (in any of our default extensions or any apps on Pop!_OS) from removing the module. It's strange that HandBrake logs a warning when it's missing if they don't want it to be present. (Steam seems to log the same warning whether the package is installed or not.)

Also worth noting that this was only a recommends, not a hard dependency, so it can already be manually removed without this PR.

mmstick commented 1 year ago

All GTK3 applications are affected by this bug in Wayland that use app menus. I wonder if Ubuntu is aware of the issue.

mmstick commented 1 year ago

Let's try also removing the gtk2 module as a depends

mmstick commented 1 year ago

GTK2 applications seems to be launching and functioning fine without the module. I recall that we had originally added this dependency in 20.04 because of https://bugs.launchpad.net/ubuntu/+bug/1891245, but they're working fine without it now.