search

pop-os / distinst

Installer Backend
GNU Lesser General Public License v3.0
222 stars 42 forks source link

Installer crashes if certain partitions are present on the system. #287

Closed foxt closed 2 years ago

foxt commented 2 years ago

Distribution (run cat /etc/os-release): Pop!_OS 21.10

Related Application and/or Package Version (run apt policy $PACKAGE NAME): distinst 0.3.2

Issue/Bug Description: If a Exfat or F2FS partition is present on the machine, the installer will crash.

Steps to reproduce (if you know):

  1. Run the installer with a machine that has a F2FS partition present.

Expected behavior: The installer works

Other Notes:

https://github.com/pop-os/distinst/blob/master/crates/external/src/block.rs#L132

Shouldn't crash with no error message! Ideally, should return none or an error message.

AleVul commented 2 years ago

I think this can be closed, see #295

foxt commented 2 years ago

That seems to fix the issue.