search

pop-os / distinst

Installer Backend
GNU Lesser General Public License v3.0
221 stars 43 forks source link

Use blkid to get label value on a f2fs partition #293

Closed AleVul closed 2 years ago

AleVul commented 2 years ago

Fixes #287

jacobgkau commented 2 years ago

This builds locally, but failed to build on the build server. The log doesn't seem to say why:

distinst: 4ec4bf5d1d4f16280b2d128b5e55a7ba11885c32 (testing-distinst-pr293): jammy (22.04): amd64: binary failed: exit code: 2
distinst: 4ec4bf5d1d4f16280b2d128b5e55a7ba11885c32 (testing-distinst-pr293): jammy (22.04): binary-amd64 github status failure
E: Build failure (dpkg-buildpackage died)
mmstick commented 2 years ago

Seems to be this

error[E0308]: mismatched types
   --> crates/external/src/block.rs:133:20
    |
133 |               return path
    |  ____________________^
134 | |                 .to_str()
135 | |                 .and_then(|value| Some(("blkid", &["-s", "LABEL", "-o", "value", value])))
    | |__________________________________________________________________________________________^ expected slice `[&'a str]`, found array `[&str; 5]`
    |
    = note: expected enum `Option<(&'a str, &'a [&'a str])>`
               found enum `Option<(&str, &[&str; 5])>`

For more information about this error, try `rustc --explain E0308`.
error: could not compile `distinst-external-commands` due to previous error
make[2]: *** [Makefile:70: target/release/distinst] Error 101
mmstick commented 2 years ago

I'll push the fix that testing PR

mmstick commented 2 years ago

I've pushed the changes to the testing branch, and fixed an issue that I saw.