search

pop-os / distinst

Installer Backend
GNU Lesser General Public License v3.0
221 stars 43 forks source link

fix: Match Vala's type signature for `DistinstUserAccountCallback` #294

Closed ids1024 closed 2 years ago

ids1024 commented 2 years ago

Valac converts a struct return value to an argument (in get_callable_creturn_type). Perhaps this worked as expected with the x86_64 calling convention, but it seems to break on arm64. This should fix that.

On arm64, this seems to fix the crash from https://github.com/pop-os/installer/issues/269. It should be the correct function signature on x86 as well, but that will need to be tested.

jackpot51 commented 2 years ago

@mmstick this did not have a QA team approval.