pop-os / distinst

Installer Backend
GNU Lesser General Public License v3.0
221 stars 43 forks source link

f2fs: change preferred options #296

Closed AleVul closed 2 years ago

AleVul commented 2 years ago

This PR changes preferred options for f2fs.

This set of options was inspired by ArchLinux's recommended options with some changes.

Rationale for some of the options:

Some of the features of f2fs must be enabled at mkfs time so that the driver could use the options above. More about this features can be found in man pages.

mmstick commented 2 years ago

Is there a reason to disable discard?

AleVul commented 2 years ago

Is there a reason to disable discard?

The only reason is to enable periodic trim for f2fs filesystems. See this and this

AleVul commented 2 years ago

Also if you try to run the install again you need to use fdisk to delete all the partitions, and then use mkfs to make the whole drive one ext4 partition.

By default, mkfs.f2fs will not write to the device if it suspects that there is a filesystem or partition table on the device already. If this is desired, we could use -f switch so that mkfs.f2fs would attempt to overwrite.

n3m0-22 commented 2 years ago

@AleVul I did a quick test with -f and it does resolve that issue. It might be good to have as it will make further testing simpler when a clean install is needed.