pop-os / distinst

Installer Backend
GNU Lesser General Public License v3.0
221 stars 43 forks source link

Install `pop-hp-vendor` on Dev One, for Pop!_OS >= 22.04 #300

Closed ids1024 closed 2 years ago

ids1024 commented 2 years ago

The package needs to be in the ISO package pool (https://github.com/pop-os/iso/pull/299) for this to work.

Not sure the easiest way to test this...

leviport commented 2 years ago

Huh, why did CI only build this for Ubuntu?

ids1024 commented 2 years ago

CI is taking a while since it's building linux. I think it will get around to the pop-os build for this eventually.

leviport commented 2 years ago

Ah I see, sorry for my impatience :sweat_smile:

ids1024 commented 2 years ago

At some point we should refactor our CI system to support multiple builds in parallel so one long build doesn't hold things up.

jackpot51 commented 2 years ago

https://github.com/pop-os/iso/pull/299 is now merged, so the ISO pool will contain the HP packages with the next ISO build. So:

  1. Build a new ISO
  2. Add this staging branch and update
  3. Kill and restart the installer
  4. Disconnect from networking (to ensure pool is correct)
  5. Install as normal
  6. EULA and HP analytics should be shown in initial setup, on HP Dev One. Background should be HP background.
leviport commented 2 years ago

Following the above procedure, I'm not seeing pop-hp-vendor post-install, and I'm not seeing EULA or analytics panels in GIS.

pop-os@pop-os:~$ apt policy distinst
distinst:
  Installed: 0.3.2~1655328219~22.04~b05faaa
  Candidate: 0.3.2~1655328219~22.04~b05faaa
  Version table:
 *** 0.3.2~1655328219~22.04~b05faaa 1002
       1002 http://apt.pop-os.org/staging/hp-vendor jammy/main amd64 Packages
        100 /var/lib/dpkg/status
     0.3.2~1652283129~22.04~4af925c 1001
       1001 http://apt.pop-os.org/release jammy/main amd64 Packages

(post install)

system76@pop-os:~$ apt policy pop-hp-vendor
pop-hp-vendor:
  Installed: (none)
  Candidate: 0.1.0~1653677894~22.04~b8e38ea
  Version table:
     0.1.0~1653677894~22.04~b8e38ea 1001
       1001 http://apt.pop-os.org/release jammy/main amd64 Packages

dmidecode, in case it's helpful: dev-one-dmidecode.txt

Edit: I also tried it without disconnecting network, to see if it was an ISO pool issue, and I got the same result.

jackpot51 commented 2 years ago

@leviport you might have to systemctl restart distinst-v2, I am not sure.

leviport commented 2 years ago

Just tried it, and that didn't seem to help either. Is there any info I can collect and share that would help?

leviport commented 2 years ago

Actually a slightly newer debug iso did build last night. I'll give that one a whirl just in case it has a fresher pool.

ids1024 commented 2 years ago

Okay, found a way to test this logic easily without installing, and it just needed to use os_release.version_id instead of os_release.version...

Should work as expected now.