pop-os / distinst

Installer Backend
GNU Lesser General Public License v3.0
221 stars 43 forks source link

GTX 1030 and RTX 4090 mistakenly being recognized by distinst as integrated graphics #314

Closed jacobktm closed 2 years ago

jacobktm commented 2 years ago

Distribution (run cat /etc/os-release):

NAME="Pop!_OS" VERSION="22.04 LTS" ID=pop ID_LIKE="ubuntu debian" PRETTY_NAME="Pop!_OS 22.04 LTS" VERSION_ID="22.04" HOME_URL="https://pop.system76.com" SUPPORT_URL="https://support.system76.com" BUG_REPORT_URL="https://github.com/pop-os/pop/issues" PRIVACY_POLICY_URL="https://system76.com/privacy" VERSION_CODENAME=jammy UBUNTU_CODENAME=jammy LOGO=distributor-logo-pop-os

Related Application and/or Package Version (run apt policy $PACKAGE NAME):

distinst: Installed: (none) Candidate: 0.3.2\~1663157572\~22.04\~d343ec3 Version table: 0.3.2\~1663157572\~22.04\~d343ec3 1001 1001 http://apt.pop-os.org/release jammy/main amd64 Packages

Issue/Bug Description:

I believe I have tracked down the cause of this issue: https://github.com/pop-os/nvidia-graphics-drivers/issues/170 to this block of code in crates/hardware/src/switchable_graphics.rs:

match default_graphics().as_str() {
        "integrated" => {
            info!("disabling external NVIDIA graphics by default");
            fs::write(mount_dir.join(POWER), MODPROBE_INTEGRATED)?;

            info!("configuring gpu-manager for integrated graphics mode");
            fs::write(mount_dir.join(PRIME_DISCRETE), "off")?;
        },
        "hybrid" => {
            info!("settings module options for hybrid graphics mode");
            fs::write(mount_dir.join(POWER), MODPROBE_HYBRID)?;

            info!("configuring gpu-manager for hybrid graphics mode");
            fs::write(mount_dir.join(PRIME_DISCRETE), "on-demand")?;
        },
        _ => (),
    }

If a GTX 1030 or RTX 4090 are installed in the system during setup it proceeds as though the system is only using integrated graphics

Steps to reproduce (if you know):

1) Install a GTX 1030 or RTX 4090 into the system with display out plugged into discrete GPU (make sure integrated graphics is enabled in BIOS) 2) install Pop! OS 22.04 from live media 3) on reboot after installing system hangs until display out plugged in to integrated graphics

Expected behavior:

System is supposed to boot normally

jacobktm commented 2 years ago

I did some more digging into this issue and I believe the actual root cause of this is here: https://github.com/pop-os/system76-power/issues/370