search

pop-os / distinst

Installer Backend
GNU Lesser General Public License v3.0
221 stars 43 forks source link

Only install --recommended drivers #320

Closed jlnr closed 1 year ago

jlnr commented 1 year ago

Coming from here https://github.com/elementary/os/issues/686#issuecomment-1697587704

ubuntu-drivers list returns a list of 9 Nvidia drivers in Ubuntu 22.04 and elementary OS 7. However, we only want to install one of them. With --recommended, only the most recent driver will be listed.

Committed from the GitHub web UI, I don't have a development environment for this right now.

jlnr commented 1 year ago

@davidmhewitt If I remember correctly, you have non-Nvidia drivers that you install using ubuntu-drivers, does my patch affect this?

davidmhewitt commented 1 year ago

Can confirm that the --recommended flag still suggests the same/correct drivers for non-Nvidia hardware. Have tested with Broadcom wireless NICs and virtualbox guest modules. So it's a +1 from me.

jlnr commented 1 year ago

One more review would be very appreciated 🙏 The current code will try to install all the Nvidia drivers at once, resulting in a non-working system (at least for me) that cannot be fixed by simply installing the right driver version later.