search

pop-os / gnome-control-center

Pop!_OS fork of https://git.launchpad.net/~ubuntu-desktop/ubuntu/+source/gnome-control-center
GNU General Public License v2.0
29 stars 10 forks source link

patches: disable 0027-window-Stop-using-HdyLeaflet.patch #103

Closed ids1024 closed 4 years ago

ids1024 commented 4 years ago

Fixes https://github.com/pop-os/gnome-control-center/issues/100.

See the description in the patch for the justification for patching this functionality out.

ids1024 commented 4 years ago

Some pages still have a higher minimum width than other pages. The most noticeable is "Mouse & Touchpad," which seems to want more padding on either side of the actual content than most of the other pages. However, this is also the case when the patch is applied, so that's not a regression.

Interesting. This seems to happen with my slightly modified build from upstream master, so it seems to be an upstream issue, and as you say, also not a regression.

I guess it doesn't have more problems than already existed, and while the Ubuntu maintainer is right that this is "less useful in the desktop case", I suppose this is more useful with tiling. So I'll merge it.

ids1024 commented 4 years ago

The most noticeable is "Mouse & Touchpad," which seems to want more padding on either side of the actual content than most of the other pages.

I've tracked down the cause of this, though I'm not sure exactly what the best solution is: https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/1046