search

pop-os / gnome-control-center

Pop!_OS fork of https://git.launchpad.net/~ubuntu-desktop/ubuntu/+source/gnome-control-center
GNU General Public License v2.0
29 stars 10 forks source link

With other icon themes, Debian logo appears in the About section of Settings #179

Open Bookingyo opened 3 years ago

Bookingyo commented 3 years ago

How did you upgrade to 21.04? (Fresh install / Upgrade)

Upgraded from 20.10 (Nvidia)

Issue/Bug Description:

Debian logo appearing in the About section of Settings Pop

Expected behavior:

Pop OS logo should appear

aman220320072007 commented 3 years ago

this is very weird indeed

jacobgkau commented 3 years ago

Thank you for trying the beta. Can you please provide the output of the following commands in a text file? This will help us determine what's causing this and how to recreate it.

gsettings get org.gnome.desktop.interface gtk-theme
gsettings get org.gnome.desktop.interface icon-theme
apt list --installed
Bookingyo commented 3 years ago

I closed this by accident.

Here you go:

Log.txt

jacobgkau commented 3 years ago

Thank you for the output. This is occurring because you've changed the icon theme.

We're using a patch that replaces the hard-coded GNOME logo with distributor-logo from the icon theme: https://github.com/pop-os/gnome-control-center/blob/288123b2c13bd493e4a0f532e591fefdf4386c29/debian/patches/distro-logo.patch

The Pop theme sets this icon to the Pop!_OS logo; the Papirus theme you're using does not include a distributor-logo icon (and its distributor-logo-debian icon looks different form this one), so I'm not sure where this fallback is coming from.

Since we're applying a patch to do this anyway, maybe we could better hard-code the Pop!_OS logo specifically. This issue happens on 20.10, so it's not specific to the 21.04 beta; I'm transferring it to the gnome-control-center repository.