search

pop-os / gnome-control-center

Pop!_OS fork of https://git.launchpad.net/~ubuntu-desktop/ubuntu/+source/gnome-control-center
GNU General Public License v2.0
29 stars 10 forks source link

Rebase to 3.38.6 #190

Closed mmstick closed 3 years ago

bflanagin commented 3 years ago

I'm not sure if this is expected, but the Cosmic Desktop options are no longer visible after the rebase as well.

jacobgkau commented 3 years ago

There's a new Power Mode section on the Power page.

Screenshot from 2021-07-28 15-49-23

This looks like it should correspond to system76-power profiles, but it doesn't. Do we want to do anything with that (connect it to system76-power or remove it)?

mmstick commented 3 years ago

We can remove it for now

ids1024 commented 3 years ago

This has reverted the Keyboard panel to the stock 3.38 version.

ids1024 commented 3 years ago

There were also changes to the Region panel along with the changes to the Keyboard panel (like moving input sources from there to the keyboard panel).

(It's a bit of a mess, but those changes are mostly upstream in Gnome 40+.)

jacobgkau commented 3 years ago

There were also changes to the Region panel along with the changes to the Keyboard panel (like moving input sources from there to the keyboard panel).

Can confirm, input sources are currently in both the Keyboard and Region panels (shouldn't be in the Region panel.)

jacobgkau commented 3 years ago

The last commit commented out 0011-region-Add-Language-Selector-button.patch, which appears to be what adds the Manage Installed Languages button.

jacobgkau commented 3 years ago

The build failed. Testing locally, the patch wasn't applying. Looking at https://github.com/pop-os/gnome-control-center/commit/3bbd03d213a291c8b38dc026b9bdb26509898096 as an example, I updated and refreshed the patch and it now appears to be working. Testing will resume once this builds on the build server again.