Firmware section crashes when expanding items to reveal changelog

[jivanpal]

When clicking on items in Settings > Firmware, sometimes the app crashes. Sometimes it crashes on the first such attempt, other times I am able to expand/collapse numerous items before a crash occurs.

Reproducible on a fresh install of Pop OS 22.04 on a Thinkpad T14 Gen 1.

Debugging output

``` jivan@pop-os:~$ RUST_BACKTRACE=full gnome-control-center unknown device key: VersionRaw (v): Variant(240) unknown device key: Protocol (v): Variant("org.uefi.capsule") unknown device key: VersionRaw (v): Variant(65544) unknown device key: VersionLowestRaw (v): Variant(65544) unknown device key: Protocol (v): Variant("org.usb.dfu") unknown device key: Protocol (v): Variant("org.uefi.capsule") unknown device key: VersionRaw (v): Variant(3761046893) unknown device key: VersionLowestRaw (v): Variant(1) unknown device key: Protocol (v): Variant("org.nvmexpress") unknown device key: Protocol (v): Variant("com.synaptics.prometheus") unknown device key: CompositeId (v): Variant("d432baa2162a32c1554ef24bd8281953b9d07c11") unknown device key: Protocol (v): Variant("com.synaptics.prometheus.config") unknown device key: Protocol (v): Variant("org.uefi.capsule") unknown device key: VersionRaw (v): Variant(65555) unknown device key: VersionRaw (v): Variant(282583078273024) unknown device key: Protocol (v): Variant("com.intel.thunderbolt") unknown device key: Protocol (v): Variant("org.uefi.capsule") unknown device key: VersionRaw (v): Variant(16842769) unknown device key: VersionLowestRaw (v): Variant(1) unknown device key: Protocol (v): Variant("org.uefi.capsule") unknown device key: VersionRaw (v): Variant(65794) unknown device key: VersionLowestRaw (v): Variant(65794) unknown device key: Protocol (v): Variant("org.uefi.capsule") unknown device key: VersionRaw (v): Variant(24580) unknown device key: VersionLowestRaw (v): Variant(1) unknown release key: ReleaseId (v) unknown release key: Created (v) unknown release key: Locations (v) unknown release key: Urgency (v) unknown release key: ReleaseId (v) unknown release key: Created (v) unknown release key: Locations (v) unknown release key: Urgency (v) unknown release key: ReleaseId (v) unknown release key: Created (v) unknown release key: Locations (v) unknown release key: Urgency (v) unknown release key: ReleaseId (v) unknown release key: Created (v) unknown release key: Locations (v) unknown release key: Urgency (v) unknown release key: ReleaseId (v) unknown release key: Created (v) unknown release key: Locations (v) unknown release key: Urgency (v) unknown release key: ReleaseId (v) unknown release key: Created (v) unknown release key: Locations (v) unknown release key: Urgency (v) unknown release key: ReleaseId (v) unknown release key: Created (v) unknown release key: Locations (v) unknown release key: Urgency (v) unknown release key: ReleaseId (v) unknown release key: Created (v) unknown release key: Locations (v) unknown release key: Urgency (v) unknown release key: ReleaseId (v) unknown release key: Created (v) unknown release key: Locations (v) unknown release key: Urgency (v) unknown release key: ReleaseId (v) unknown release key: Created (v) unknown release key: Locations (v) unknown release key: Urgency (v) unknown release key: ReleaseId (v) unknown release key: Created (v) unknown release key: Locations (v) unknown release key: ReleaseId (v) unknown release key: Created (v) unknown release key: Locations (v) unknown release key: Urgency (v) unknown release key: ReleaseId (v) unknown release key: Created (v) unknown release key: Locations (v) unknown release key: Urgency (v) thread '' panicked at 'called `Result::unwrap()` on an `Err` value: BoolError { message: "Invalid return value: expected (), got gboolean", filename: "/build/firmware-manager-MLlsib/firmware-manager-0.1.2~1668129621~22.04~3ded128/vendor/glib/src/closure.rs", function: "glib::closure", line: 365 }', /build/firmware-manager-MLlsib/firmware-manager-0.1.2~1668129621~22.04~3ded128/vendor/glib/src/object.rs:2968:50 stack backtrace: 0: 0x7fa3a46bef80 - 1: 0x7fa3a46e455e - 2: 0x7fa3a46b8915 - 3: 0x7fa3a46c07b3 - 4: 0x7fa3a46c049f - 5: 0x7fa3a46c0e5a - 6: 0x7fa3a46c0d57 - 7: 0x7fa3a46bf42c - 8: 0x7fa3a46c0a72 - 9: 0x7fa3a42dbd33 - 10: 0x7fa3a42dbe83 - 11: 0x7fa3a432767c - 12: 0x7fa3a431f902 - 13: 0x7fa3a65a7745 - g_cclosure_marshal_VOID__OBJECTv 14: 0x7fa3a65c6640 - g_signal_emit_valist 15: 0x7fa3a65c67a3 - g_signal_emit 16: 0x7fa3a5c46a89 - 17: 0x7fa3a5df0be5 - 18: 0x7fa3a65c6640 - g_signal_emit_valist 19: 0x7fa3a65c67a3 - g_signal_emit 20: 0x7fa3a5c07ffc - 21: 0x7fa3a65ad866 - g_cclosure_marshal_VOID__BOXEDv 22: 0x7fa3a65c6640 - g_signal_emit_valist 23: 0x7fa3a65c67a3 - g_signal_emit 24: 0x7fa3a5bffacb - 25: 0x7fa3a5c0783b - 26: 0x7fa3a5c08443 - 27: 0x7fa3a5bcef90 - gtk_event_controller_handle_event 28: 0x7fa3a5da0045 - 29: 0x7fa3a5de6eb8 - 30: 0x7fa3a65c6640 - g_signal_emit_valist 31: 0x7fa3a65c67a3 - g_signal_emit 32: 0x7fa3a5dae724 - 33: 0x7fa3a5c51680 - 34: 0x7fa3a5c5252a - gtk_main_do_event 35: 0x7fa3a62e0743 - 36: 0x7fa3a6317f56 - 37: 0x7fa3a64afd1b - g_main_context_dispatch 38: 0x7fa3a65046f8 - 39: 0x7fa3a64ad3c3 - g_main_context_iteration 40: 0x7fa3a66d4c85 - g_application_run 41: 0x55b26e974d83 - main 42: 0x7fa3a3229d90 - 43: 0x7fa3a3229e40 - __libc_start_main 44: 0x55b26e974f65 - _start 45: 0x0 - fatal runtime error: failed to initiate panic, error 5 Aborted (core dumped) ```

[n3m0-22]

I can confirm this issue.

Pop!_OS 22.04 lemp11 b337ac6 firmare

Output:

``` ../src/intel/isl/isl.c:2216: FINISHME: ../src/intel/isl/isl.c:isl_surf_supports_ccs: CCS for 3D textures is disabled, but a workaround is available. unknown device key: Protocol (v): Variant("tw.com.emc.elantp") unknown device key: VersionRaw (v): Variant(1057) unknown device key: Protocol (v): Variant("org.nvmexpress") unknown device key: Protocol (v): Variant("org.nvmexpress") unknown device key: VersionRaw (v): Variant(1970689910360832) unknown device key: Protocol (v): Variant("com.intel.thunderbolt") unknown device key: Protocol (v): Variant("com.logitech.unifyingsigned") thread '' panicked at 'called `Result::unwrap()` on an `Err` value: BoolError { message: "Invalid return value: expected (), got gboolean", filename: "/build/firmware-manager-MLlsib/firmware-manager-0.1.2~1668129621~22.04~3ded128/vendor/glib/src/closure.rs", function: "glib::closure", line: 365 }', /build/firmware-manager-MLlsib/firmware-manager-0.1.2~1668129621~22.04~3ded128/vendor/glib/src/object.rs:2968:50 stack backtrace: 0: 0x7f42f52bef80 - 1: 0x7f42f52e455e - 2: 0x7f42f52b8915 - 3: 0x7f42f52c07b3 - 4: 0x7f42f52c049f - 5: 0x7f42f52c0e5a - 6: 0x7f42f52c0d57 - 7: 0x7f42f52bf42c - 8: 0x7f42f52c0a72 - 9: 0x7f42f4edbd33 - 10: 0x7f42f4edbe83 - 11: 0x7f42f4f2767c - 12: 0x7f42f4f1f902 - 13: 0x7f42f7156745 - g_cclosure_marshal_VOID__OBJECTv 14: 0x7f42f7175640 - g_signal_emit_valist 15: 0x7f42f71757a3 - g_signal_emit 16: 0x7f42f6846a89 - 17: 0x7f42f69f0be5 - 18: 0x7f42f7175640 - g_signal_emit_valist 19: 0x7f42f71757a3 - g_signal_emit 20: 0x7f42f6807ffc - 21: 0x7f42f715c866 - g_cclosure_marshal_VOID__BOXEDv 22: 0x7f42f7175640 - g_signal_emit_valist 23: 0x7f42f71757a3 - g_signal_emit 24: 0x7f42f67ffacb - 25: 0x7f42f680783b - 26: 0x7f42f6808443 - 27: 0x7f42f67cef90 - gtk_event_controller_handle_event 28: 0x7f42f69a0045 - 29: 0x7f42f69e6eb8 - 30: 0x7f42f7175640 - g_signal_emit_valist 31: 0x7f42f71757a3 - g_signal_emit 32: 0x7f42f69ae724 - 33: 0x7f42f6851680 - 34: 0x7f42f685252a - gtk_main_do_event 35: 0x7f42f6e8f743 - 36: 0x7f42f6ec6f56 - 37: 0x7f42f705ed1b - g_main_context_dispatch 38: 0x7f42f70b36f8 - 39: 0x7f42f705c3c3 - g_main_context_iteration 40: 0x7f42f7283c85 - g_application_run 41: 0x557e9eee2d83 - main 42: 0x7f42f3e29d90 - 43: 0x7f42f3e29e40 - __libc_start_main 44: 0x557e9eee2f65 - _start 45: 0x0 - fatal runtime error: failed to initiate panic, error 5 Aborted (core dumped) ```

[n3m0-22]

This appears to still be an issue. I can confirm I am still able to reproduce it. https://github.com/pop-os/gnome-control-center/issues/239

[nonergodic]

Yep, running into the crash too:

RUST_BACKTRACE=full gnome-control-center
unknown device key: VersionRaw (v): Variant(167805443)
unknown device key: CompositeId (v): Variant("4bde70ba4e39b28f9eab1628f9dd6e6244c03027")
unknown device key: Protocol (v): Variant("org.nvmexpress")
unknown device key: CompositeId (v): Variant("4bde70ba4e39b28f9eab1628f9dd6e6244c03027")
unknown device key: Protocol (v): Variant("org.uefi.capsule")
unknown device key: VersionRaw (v): Variant(4099)
unknown device key: VersionLowestRaw (v): Variant(4099)
unknown device key: VersionRaw (v): Variant(844751347777541)
unknown device key: CompositeId (v): Variant("a45df35ac0e948ee180fe216a5f703f32dda163f")
unknown device key: CompositeId (v): Variant("a45df35ac0e948ee180fe216a5f703f32dda163f")
unknown device key: Protocol (v): Variant("org.uefi.dbx")
unknown device key: Protocol (v): Variant("com.logitech.unifyingsigned")
thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: BoolError { message: "Invalid return value: expected (), got gboolean", filename: "/build/firmware-manager-rLY3OS/firmware-manager-0.1.2~1683137852~22.04~c9367bb/vendor/glib/src/closure.rs", function: "glib::closure", line: 365 }', /build/firmware-manager-rLY3OS/firmware-manager-0.1.2~1683137852~22.04~c9367bb/vendor/glib/src/object.rs:2968:50
stack backtrace:
   0:     0x7fcb1b96f59a - <unknown>
   1:     0x7fcb1b996f6e - <unknown>
   2:     0x7fcb1b96b675 - <unknown>
   3:     0x7fcb1b96f365 - <unknown>
   4:     0x7fcb1b970b1f - <unknown>
   5:     0x7fcb1b97085b - <unknown>
   6:     0x7fcb1b9710c8 - <unknown>
   7:     0x7fcb1b970fc9 - <unknown>
   8:     0x7fcb1b96fa06 - <unknown>
   9:     0x7fcb1b970cd2 - <unknown>
  10:     0x7fcb1b4ef4a3 - <unknown>
  11:     0x7fcb1b4ef953 - <unknown>
  12:     0x7fcb1b535438 - <unknown>
  13:     0x7fcb1b5379c0 - <unknown>
  14:     0x7fcb1d74c745 - g_cclosure_marshal_VOID__OBJECTv
  15:     0x7fcb1d76b700 - g_signal_emit_valist
  16:     0x7fcb1d76b863 - g_signal_emit
  17:     0x7fcb1ce46a89 - <unknown>
  18:     0x7fcb1cff0be5 - <unknown>
  19:     0x7fcb1d76b700 - g_signal_emit_valist
  20:     0x7fcb1d76b863 - g_signal_emit
  21:     0x7fcb1ce07ffc - <unknown>
  22:     0x7fcb1d752866 - g_cclosure_marshal_VOID__BOXEDv
  23:     0x7fcb1d76b700 - g_signal_emit_valist
  24:     0x7fcb1d76b863 - g_signal_emit
  25:     0x7fcb1cdffacb - <unknown>
  26:     0x7fcb1ce0783b - <unknown>
  27:     0x7fcb1ce08443 - <unknown>
  28:     0x7fcb1cdcef90 - gtk_event_controller_handle_event
  29:     0x7fcb1cfa0045 - <unknown>
  30:     0x7fcb1cfe6eb8 - <unknown>
  31:     0x7fcb1d76b700 - g_signal_emit_valist
  32:     0x7fcb1d76b863 - g_signal_emit
  33:     0x7fcb1cfae724 - <unknown>
  34:     0x7fcb1ce51680 - <unknown>
  35:     0x7fcb1ce5252a - gtk_main_do_event
  36:     0x7fcb1d485743 - <unknown>
  37:     0x7fcb1d4bcf56 - <unknown>
  38:     0x7fcb1d654d3b - g_main_context_dispatch
  39:     0x7fcb1d6a96c8 - <unknown>
  40:     0x7fcb1d6523e3 - g_main_context_iteration
  41:     0x7fcb1d879fb5 - g_application_run
  42:     0x55f4500e2d83 - main
  43:     0x7fcb1a229d90 - <unknown>
  44:     0x7fcb1a229e40 - __libc_start_main
  45:     0x55f4500e2f65 - _start
  46:                0x0 - <unknown>
fatal runtime error: failed to initiate panic, error 5
Aborted (core dumped)

[rbreddy]

I am facing the same error: thread '' panicked at 'called Result::unwrap() on an Err value: BoolError { message: "Invalid return value: expected (), got gboolean", filename: "/build/firmware-manager-rLY3OS/firmware-manager-0.1.2~1683137852~22.04~c9367bb/vendor/glib/src/closure.rs", function: "glib::closure", line: 365 }', /build/firmware-manager-rLY3OS/firmware-manager-0.1.2~1683137852~22.04~c9367bb/vendor/glib/src/object.rs:2968:50 stack backtrace: 0: 0x7f6caf76f59a - 1: 0x7f6caf796f6e - 2: 0x7f6caf76b675 - 3: 0x7f6caf76f365 - 4: 0x7f6caf770b1f - 5: 0x7f6caf77085b - 6: 0x7f6caf7710c8 - 7: 0x7f6caf770fc9 - 8: 0x7f6caf76fa06 - 9: 0x7f6caf770cd2 - 10: 0x7f6caf2ef4a3 - 11: 0x7f6caf2ef953 - 12: 0x7f6caf335438 - 13: 0x7f6caf3379c0 - 14: 0x7f6cb1681745 - g_cclosure_marshal_VOIDOBJECTv 15: 0x7f6cb16a0700 - g_signal_emit_valist 16: 0x7f6cb16a0863 - g_signal_emit 17: 0x7f6cb0e46a89 - 18: 0x7f6cb0ff0be5 - 19: 0x7f6cb16a0700 - g_signal_emit_valist 20: 0x7f6cb16a0863 - g_signal_emit 21: 0x7f6cb0e07ffc - 22: 0x7f6cb1687866 - g_cclosure_marshal_VOID__BOXEDv 23: 0x7f6cb16a0700 - g_signal_emit_valist 24: 0x7f6cb16a0863 - g_signal_emit 25: 0x7f6cb0dffacb - 26: 0x7f6cb0e0783b - 27: 0x7f6cb0e08443 - 28: 0x7f6cb0dcef90 - gtk_event_controller_handle_event 29: 0x7f6cb0fa0045 - 30: 0x7f6cb0fe6eb8 - 31: 0x7f6cb16a0700 - g_signal_emit_valist 32: 0x7f6cb16a0863 - g_signal_emit 33: 0x7f6cb0fae724 - 34: 0x7f6cb0e51680 - 35: 0x7f6cb0e5252a - gtk_main_do_event 36: 0x7f6cb0b32743 - 37: 0x7f6cb0b69f56 - 38: 0x7f6cb1589d3b - g_main_context_dispatch 39: 0x7f6cb15de6c8 - 40: 0x7f6cb15873e3 - g_main_context_iteration 41: 0x7f6cb17aefb5 - g_application_run 42: 0x55ff73bd2d83 - main 43: 0x7f6cae229d90 - 44: 0x7f6cae229e40 - libc_start_main 45: 0x55ff73bd2f65 - _start 46: 0x0 - fatal runtime error: failed to initiate panic, error 5 Aborted

Let me know if I can provide more information

[evnct]

Can replicate on Lenovo Thinkpad T460S. Occasionally works but most of time crashes.

``` Jul 9 19:08:08 pop-os gnome-firmware-panel.desktop[5657]: thread '' panicked at 'called `Result::unwrap()` on an `Err` value: BoolError { message: "Invalid return value: expected (), got gboolean", filename: "/build/firmware-manager-rLY3OS/firmware-manager-0.1.2~1683137852~22.04~c9367bb/vendor/glib/src/closure.rs", function: "glib::closure", line: 365 }', /build/firmware-manager-rLY3OS/firmware-manager-0.1.2~1683137852~22.04~c9367bb/vendor/glib/src/object.rs:2968:50 Jul 9 19:08:08 pop-os gnome-firmware-panel.desktop[5657]: note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace Jul 9 19:08:08 pop-os gnome-firmware-panel.desktop[5657]: fatal runtime error: failed to initiate panic, error 5 ```

[ghost]

This is also an issue on my Thinkpad X1 Carbon Gen 9

Jul 20 11:24:38 sanderblom-x1 gnome-control-center.desktop[14366]: thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: BoolError { message: "Invalid return value: expected (), got gboolean", filename: "/build/firmware-manager-rLY3OS/firmware-manager-0.1.2~1683137852~22.04~c9367bb/vendor/glib/src/closure.rs", function: "glib::closure", line: 365 }', /build/firmware-manager-rLY3OS/firmware-manager-0.1.2~1683137852~22.04~c9367bb/vendor/glib/src/object.rs:2968:50
Jul 20 11:24:38 sanderblom-x1 gnome-control-center.desktop[14366]: note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
Jul 20 11:24:38 sanderblom-x1 gnome-control-center.desktop[14366]: fatal runtime error: failed to initiate panic, error 5
Jul 20 11:24:39 sanderblom-x1 systemd[1233]: app-gnome-gnome\x2dcontrol\x2dcenter-14366.scope: Consumed 2.152s CPU time.

[Vishal040393]

Same for me on my Hp Dev One laptop. Whenever I open Settings, go to Firmware, and click Changelog. The Settings window automatically closes down.

[basictask]

Is this still not solved? I am having the same issue on Intel-i9 12900H

[leviport]

I'm currently testing a PR that may improve the situation: https://github.com/pop-os/firmware-manager/pull/152

[jivanpal]

This appears to be fixed, as I no longer seem to experience this bug. Currently running gnome-control-center v41.4 on the same machine as in the original post, but notably on an effectively new installation of Pop OS that was created using the "repair installation" feature of the USB installer.