Open maria-komarova opened 4 years ago
A few comments/questions/concerns:
Responding to the comments above.
The designs below should cover the raised concerns about the instructions. The absence of the button was an accident. The reason for not reusing the current window is because from my conversations with users and observing people's reactions, majority find the window to be somewhat confusing, especially those who see it first time. We at least need to include the buttons for canceling and saving the shortcut instead of the current instructions to press Esc or Backspace to either close the dialog or disable the shortcut.
I changed the design for creating a custom shortcut. The following mockups show the flow for setting one. The application field helps users to set a shortcut to launch a frequently used application. When one selects an application from the dropdown, the command field for launching the application automatically populates. Some commands are extremely difficult to guess and with addition of the Flatpak, guessing or knowing the commands will be even harder. The duplicate message for the key combination would appear on this window as well:
Thank you for those updates @maria-komarova . Looking at what the "Application" field does, I have two additional thoughts:
Thank you for the feedback @brs17.
@maria-komarova, what I was envisioning was that the "Command" field can be filled in with a combination of text input or from the dropdown. If an application is selected from the dropdown, it appends the command required to launch such an application to the end of the "Command" text field. I don't see that as being clunky.
@maria-komarova We can do a ComboBoxText widget with an entry, which allows the user to type or select to pre-fill text from the dropdown menu. I can mock this up for you if you'd like to see it live.
The ComboBoxText widget doesn't work in this use case. You can't start typing "pop" to create a shortcut for Pop Shop. It won't find "io.elementary.appcenter". Typing in the box would yield inconsistent results (filling out an app name if you guess the command correctly and nothing when you don't).
We have a couple options. First, fill in the command text box with the command of the chosen application and grey out the entry. Second, don't grey the entry and allow the user to append flags to the application command.
I prefer the second option because it seems harmless to let the user append something to the command and if it greys out, and they want to append something, they won't have to write down or remember the command. I'm also not sure what's gained if we grey out the box.
Do you guys think changing the application list default text to “Choose Application (optional)” would help?
We’ll build mockups to test the UX as well.
I have done a round of usability testing with 6 users. None of them had any particular difficulty or confusion about the application dropdown. Some of them found having a pre-populated command helpful, especially the non-power users. Power users were more concerned with being able to edit the command once it appears in the corresponding input field. But they also found it useful to have a command shown to them. I have excerpts with quotes from the usability testing if anyone would like to see more details. Just let me know.
I am also including the updated designs with Arrow keys as a separate category of shortcuts. That way we can use Arrow keys in the popup with keyboard shortcuts.
I am not sure we will stay with an idea of the overlay with shortcuts. I am refining the popup with keyboard shortcuts for Pop Shell and will create a separate issue in the Pop Shell repository for that.
Here are the new designs:
All the functionality for changing Arrow keys should stay the same as for other shortcuts. The only difference is that once a user sets a new Arrow key, for instance, "W" as an alternative to "Up", a user should see a confirmation dialog that would list all the shortcuts that use "Up" in them.
To get closer to how the page might work in the upstream, the shortcut categories should become separate sub-pages. Each category should include information on the number of modified shortcuts in each section.
Use GTK theme styling for the keycaps.
Pop Shell will introduce new keyboard shortcuts for easier window movement and management. The overlay with keyboard shortcuts will display desktop keyboard navigation shortcuts to aid users can't or don't want to use the mouse. It shows on a long press of the Super key. Along with the overlay, there are designs for the update of the keyboard shortcuts page in Settings.
1.The first design shows the first view of the page - a user sees the categories of shortcuts. There is a setting at the bottom of the page where a user can toggle the overlay on and off.
The view of the page with one of the categories expanded to show the list of shortcuts. The new design allows to have multiple shortcuts under each action. For example, to have shortcuts that use direction keys along with their alternatives.
There are system shortcuts and custom shortcuts. They have different customization levels. Below are the designs for the dropdown menus for each shortcut. System shortcuts can be reset to default (in some cases) or disabled. You can also add another shortcut to an action.
A user can add another shortcut to an action associated with the custom shortcut. Custom shortcuts can also be removed. When there are multiple shortcuts a user has a choice of which set of keys to remove. Once a user is down to one set of keys, the wording changes to simply "Remove", as shown below.
A user can change a system shortcut to customize it by selecting a shortcut and clicking on it (see hover state shown below). To change a shortcut, one should simply type a new set of keys for the shortcut in the input field.
The next design shows the messaging if one of the shortcuts is already taken by another one. The message is the same as in the current design.
To add a custom shortcut, a user should specify the name, the command, and the shortcut itself. A user also has an option to specify the category where to place a shortcut and an application, if a shortcut is related to one. The screen below shows those two fields pre-filled - those fields should always be set to "custom shortcuts" and "none" by default to make sure a user can leave them unspecified.
The last screen shows how to list the search results - very similar to how it currently works.
Two designs for the overlay for the light and dark theme: