search

pop-os / gnome-initial-setup

Pop!_OS fork of https://git.launchpad.net/~ubuntu-desktop/ubuntu/+source/gnome-initial-setup
Other
5 stars 3 forks source link

fix: Fix copying of bad keyring file to newly-created account #53

Closed mmstick closed 5 years ago

mmstick commented 5 years ago

This seems to fix the login keyring being corrupt on a newly-created account created by initial setup.

Closes #52

WatchMkr commented 5 years ago

This fix requires new ISO’s if it’s good.

mmstick commented 5 years ago

Indeed. It can be tested on any existing 19.10 install by deleting all user accounts and restarting, which will trigger initial setup to create a new user account again. Opening Seahorse and clicking on the Login keyring should display that the keyring is unlocked, and logging out and logging back in should have it continue to report that it's unlocked.

WatchMkr commented 5 years ago

Have you also tested adding a google account? That’s where things would go badly in my testing. Even if setting up the google account after installation.

mmstick commented 5 years ago

I haven't seen any issues with adding a google account so far. It stores its credentials in the keyring, which may be why it was having issues with the bad keyring.

leviport commented 5 years ago

It looks like this wasn't built for Disco. Wouldn't we want it there since many upgrades from Disco had this issue?

jackpot51 commented 5 years ago

If they are already on Disco, they have already run through this code.