pop-os / gnome-shell-extension-system76-power

System76 Power Management Extension
MIT License
90 stars 26 forks source link

Implement Wiki Enhancements #9

Closed mmstick closed 6 years ago

mmstick commented 6 years ago

Implementing the enhancements outlined in the Wiki.

menu-descriptions hotplug-dialog preparing-nvidia restart-nvidia

mmstick commented 6 years ago

@cassidyjames I've been able to get everything but the spinner implemented so far.

cassidyjames commented 6 years ago

@mmstick awesome! There's a little thing with the icon size and text alignment… I know the Shutdown dialog has the secondary text left-aligned with the primary text, and I think the icon is bigger. Is that something we can do for consistency with existing Shell dialogs?

The spinner is probably fine to skip. The only place I can think of for reference would be the app menu loading spinner on the panel, but if we can't do it easily, I think I can find another acceptable icon.

cassidyjames commented 6 years ago

shutdown dialog for reference screenshot from 2018-06-14 14 19 27

mmstick commented 6 years ago

@cassidyjames I can change the alignment.

mmstick commented 6 years ago

@cassidyjames How's this?

screenshot from 2018-06-14 14-45-09

cassidyjames commented 6 years ago

@mmstick it's hard to tell exactly without getting the ruler out, but that looks really close to me. :+1:

cassidyjames commented 6 years ago

@mmstick okay I got out the ruler. Looks like Shell is using 48px icons instead of 64.

mmstick commented 6 years ago

@cassidyjames Yeah, using 48px icons here.