search

pop-os / gnome-shell-theme

The GNOME Shell theme for Pop!_OS
GNU General Public License v2.0
36 stars 10 forks source link

Pop theme css causes gnome-shell to litter the system logs #68

Closed calenlas closed 5 years ago

calenlas commented 5 years ago

Reporter info

 * Distribution - Pop!_OS 18.10
 * Gtk+ 3.0 version - 3.24.1-1ubuntu2
 * Desktop environment - Gnome
 * Pop version - 4.0.2

Actual issue

The Pop themes cause gnome-shell to litter the system logs with warnings that "+ combinators are not supported". This appears to be caused by several + combinators in the theme css bouncing off gnome-shell's st-theme.c parser around line 794 where it clearly warns about the + combinators and then ignores them. I'd suspect, as a result, that some element in the UI is not getting the intended styling.

Steps to reproduce

Use one of the Pop themes with gnome-shell and run journalctl to see the noisome warning lines.

calenlas commented 5 years ago

Likewise, there's something else in the theme css causing the theme parser to warn about "Ignoring excess values in shadow definition".

intchanter commented 5 years ago

I noticed these copious log messages when I opened journalctl -f to check for unrelated items.

My system info:

 * Distribution - Pop!_OS 18.10
 * Gtk+ 3.0 version - 3.24.1-1ubuntu2
 * Desktop environment - Gnome
 * Pop version - 4.0.2
intchanter commented 5 years ago

I'm not sure if this is connected to the same issue, but I also get these additional lines when locking and unlocking my system:

Jan 08 11:56:15 pop-os gnome-shell[2883]: st_widget_get_theme_node called on the widget [0x55ecf8a547e0 StBoxLayout ("Do not disturb")] which is not in the stage.
Jan 08 11:56:15 pop-os gnome-shell[2883]: st_widget_get_theme_node called on the widget [0x55ecfa330380 StBoxLayout.popup-menu-item do-not-disturb:last-child first-child ("Do not disturb")] which is not in the stage.
Jan 08 11:56:15 pop-os gnome-shell[2883]: st_widget_get_theme_node called on the widget [0x55ecf8a547e0 StBoxLayout ("Do not disturb")] which is not in the stage.
Jan 08 11:56:15 pop-os gnome-shell[2883]: st_widget_get_theme_node called on the widget [0x55ecfa330380 StBoxLayout.popup-menu-item do-not-disturb:last-child first-child ("Do not disturb")] which is not in the stage.
Jan 08 11:56:15 pop-os gnome-shell[2883]: st_widget_get_theme_node called on the widget [0x55ecf7d1df50 StBin:first-child] which is not in the stage.
Jan 08 11:56:15 pop-os gnome-shell[2883]: st_widget_get_theme_node called on the widget [0x55ecf8a547e0 StBoxLayout ("Do not disturb")] which is not in the stage.
Jan 08 11:56:15 pop-os gnome-shell[2883]: st_widget_get_theme_node called on the widget [0x55ecfa330380 StBoxLayout.popup-menu-item do-not-disturb:last-child first-child ("Do not disturb")] which is not in the stage.
Jan 08 11:56:15 pop-os gnome-shell[2883]: st_widget_get_theme_node called on the widget [0x55ecf7d1df50 StBin:first-child] which is not in the stage.
Jan 08 11:56:15 pop-os gnome-shell[2883]: st_widget_get_theme_node called on the widget [0x55ecf93d3890 StBin.toggle-switch toggle-switch-us:last-child first-child] which is not in the stage.
Jan 08 11:56:15 pop-os gnome-shell[2883]: st_widget_get_theme_node called on the widget [0x55ecf8a547e0 StBoxLayout ("Do not disturb")] which is not in the stage.
Jan 08 11:56:15 pop-os gnome-shell[2883]: st_widget_get_theme_node called on the widget [0x55ecfa330380 StBoxLayout.popup-menu-item do-not-disturb:last-child first-child ("Do not disturb")] which is not in the stage.
Jan 08 11:56:15 pop-os gnome-shell[2883]: st_widget_get_theme_node called on the widget [0x55ecf8e4e9c0 StLabel:last-child ("Do not disturb")] which is not in the stage.
Jan 08 11:56:15 pop-os gnome-shell[2883]: clutter_actor_remove_child: assertion 'child->priv->parent != NULL' failed