search

pop-os / gnome-shell-theme

The GNOME Shell theme for Pop!_OS
GNU General Public License v2.0
36 stars 10 forks source link

Enforce a fixed width on the Password dialog. #82

Closed isantop closed 5 years ago

isantop commented 5 years ago

We want to have a set width on the password dialog to prevent it from changing size when long passwords are typed. This PR sets a fixed size for the password dialog without setting it for other types of dialogs (preventing a reappearance of #74 ).

(#73 may still show up on the password dialog only).

Fixes pop-os/gtk-theme#275

isantop commented 5 years ago

@brs17 I can make it large enough to fit this text, but the problem with setting a fixed width for ST dialogs is that the text can't wrap, only truncate. So it will always be possible for the window to be too narrow to hold the contents.

If we use a variable width (i.e. using min-width instead of width), then the dialog grows if the password is longer than the entry, regardless of how large the window is initially set (essentially the bug this PR is intended to fix).

brs17 commented 5 years ago

@isantop yeah, after posting that I realized even without the patch there are certain messages that are truncated.

Sounds to me like an upstream issue that messages can be truncated without the ability to read the full message. Would you say that is correct?

isantop commented 5 years ago

@brs17 Yeah. The way ST draws labels needs to be redone so that messages can wrap to new lines.