search

pop-os / gnome-shell

Pop!_OS fork of https://git.launchpad.net/~ubuntu-desktop/ubuntu/+source/gnome-shell
GNU General Public License v2.0
25 stars 4 forks source link

fix: Prevent notifications disappearing on app focus #109

Closed mmstick closed 2 years ago

mmstick commented 2 years ago

Fixes notifications disappearing when an application is focused. Such as Firefox notifications. Cinnamon did the same thing 4 years ago

XV-02 commented 2 years ago

Can you recommend a set of applications which routinely throw notifications which would otherwise be dismissed without this? Additionally, does this only apply to when the application with notifications is made the focus, or when focus changes to or from the application?

jacobgkau commented 2 years ago

Can you recommend a set of applications which routinely throw notifications which would otherwise be dismissed without this?

I've heard Firefox is affected by this, and a website such as https://www.bennish.net/web-notifications.html can be used to test Firefox notifications.

jacobgkau commented 2 years ago

This leaves the notification in the notifications drop-down after I've gone to the app and seen what it was notifying me about, which I personally find slightly annoying. It sounds like multiple members of engineering are for the change. We may want to check with UX about it.

jacobgkau commented 2 years ago

@maria-komarova Thoughts on this notification behavior change?

Before, the notification would go away when focusing the app that sent the notification, assuming you're seeing what the notification was about if you're now using the app:

https://user-images.githubusercontent.com/7199422/169890703-dc6004d4-b78c-4adb-92dc-932f864d381b.mp4

After, the notification stays on the screen covering up the app even when I switch to the app, and it remains in the notification drop-down until manually dismissed:

https://user-images.githubusercontent.com/7199422/169890451-6d9af6fc-b3b1-45c8-9620-e778c431967b.mp4

jacobgkau commented 2 years ago

After discussing this with Maria and Jeremy in Mattermost early last week, it was decided this change isn't something we want to make. If there's a way to make individual applications (e.g. Firefox) send notifications less ephemerally, that would be a better way to handle it. Closing the PR for now unless there are any other objections/changes to be made.