Rework persistent offloading based on upstream

pop-os / gnome-shell

Pop!_OS fork of https://git.launchpad.net/~ubuntu-desktop/ubuntu/+source/gnome-shell

GNU General Public License v2.0

25 stars 4 forks source link

Rework persistent offloading based on upstream #24

Closed crawfxrd closed 4 years ago

crawfxrd commented 4 years ago

fd.o has accepted the name PrefersNonDefaultGPU [1] and Bastien is working on integrating it into gnome-shell [2].

Use PrefersNonDefaultGPU instead of X-KDE-RunOnDiscreteGpu
Preserve shell_app_launch() signature for extensions (Resolves: #26)

jackpot51 commented 4 years ago

Don't want to make this too complicated, but is there a reason not to check for both? Is X-KDE-RunOnDiscreteGpu deprecated?

crawfxrd commented 4 years ago

PrefersNonDefaultGPU is the standardized name for X-KDE-RunOnDiscreteGpu. GNOME is implementing the feature only after having the entry added to the XDG spec, so they have no reason to check for the KDE-specific name.

Applications used across multiple desktop environments should probably check for both. Such as what Bastien did in xdg/desktop-file-utils!7.

crawfxrd commented 4 years ago

They've decided to use "Integrated" for the user visible text ("Default" too similar to "Dedicated"), so I've changed it back to that.

crawfxrd commented 4 years ago

Updated to preserve the signature of shell_app_launch() from GNOME 3.36 so extensions can use it without breaking.