search

pop-os / gnome-shell

Pop!_OS fork of https://git.launchpad.net/~ubuntu-desktop/ubuntu/+source/gnome-shell
GNU General Public License v2.0
25 stars 4 forks source link

Rename `Show the overview` to `Show workspaces` #69

Closed jacobgkau closed 3 years ago

jacobgkau commented 3 years ago

Fixes https://github.com/pop-os/gnome-control-center/issues/166.

This is the current shortcut. The legacy shortcut is defined in Mutter (see https://github.com/pop-os/mutter/pull/22.)

jacobgkau commented 3 years ago

Before: Screenshot from 2021-06-08 11-10-24

After this and https://github.com/pop-os/mutter/pull/22: Screenshot from 2021-06-08 12-59-37 Screenshot from 2021-06-08 12-59-43

jacobgkau commented 3 years ago

Something to consider, for non-English languages this will break the translation (it will show up as Show workspaces no matter what.) If we'd rather have other languages use their translation of Show the overview, changing the msgid for all the languages should accomplish that.

If it's relevant to deciding the above, the Workspaces button itself is currently not translated in COSMIC.

(I was initially just going to change the English message via the translation, but there's no .po file for en_US.)