search

pop-os / gnome-shell

Pop!_OS fork of https://git.launchpad.net/~ubuntu-desktop/ubuntu/+source/gnome-shell
GNU General Public License v2.0
25 stars 4 forks source link

upstream pop-dark-theme.patch #77

Closed Muqtxdir closed 2 years ago

Muqtxdir commented 2 years ago

Hi 👋

I've always loved Pop!_OS's ability to switch both GTK and gnome-shell theme simultaneously without the need of user-themes gnome-shell-extension. I'd be helpful if the pop-dark-theme.patch be upstreamed so that Ubuntu's Yaru could also benefit from this on ubuntu-desktop session. I filed the bug LP: #1943857 with the patch on Launchpad and it was suggested to me that I should open an MR here.

I request the concerned devs behind this patch to open MR instead of me as it should be credited to their name for their contribution.

Thanks!

jackpot51 commented 2 years ago

Sounds good, I will make a PR

jackpot51 commented 2 years ago

I wanted to provide an update. My salsa.debian.org account requires administrator approval at this time.

Muqtxdir commented 2 years ago

My salsa.debian.org account requires administrator approval at this time.

thanks for the update, I don't know whether the MR would be merged for 21.10 as it's way beyond Freeze date. (sorry mistake on my part should have known better when's the Freeze date for the release)

jackpot51 commented 2 years ago

I'm still waiting. I don't really see a reason the change has to come from me or be attributed to me. If Ubuntu is interested, they can feel free to copy the patch.

Muqtxdir commented 2 years ago

Thanks for the permission, I'll create MR with patch 👍