pop-os / gnome-shell

Pop!_OS fork of https://git.launchpad.net/~ubuntu-desktop/ubuntu/+source/gnome-shell
GNU General Public License v2.0
25 stars 4 forks source link

debian/patches: Don't apply env vars in NVIDIA mode #84

Closed crawfxrd closed 2 years ago

crawfxrd commented 2 years ago

Do not apply env vars to the launching app if in NVIDIA-only mode. Fixes NVIDIA driver crash on the new 510 drivers when launching Steam.

jacobgkau commented 2 years ago

Slight correction, attempting to launch anything from the Pop!_Shell Launcher or COSMIC Applications menu crashes GNOME Shell. Launching things from COSMIC Dock does not crash GNOME Shell.

Logs: out.txt

Starts with:

Feb 23 09:18:21 pop-os gnome-shell[4945]: free(): invalid pointer
Feb 23 09:18:21 pop-os steam.desktop[5268]: steam.sh[5268]: Running Steam on pop 21.10 64-bit
Feb 23 09:18:21 pop-os steam.desktop[5268]: steam.sh[5268]: STEAM_RUNTIME is enabled automatically
Feb 23 09:18:21 pop-os steam.desktop[5338]: setup.sh[5338]: Steam runtime environment up-to-date!
Feb 23 09:18:21 pop-os polkitd(authority=local)[1061]: Unregistered Authentication Agent for unix-session:2 (system bus name :1.138, object path /org/freedesktop/PolicyKit1/AuthenticationAgent, locale en_US.UTF-8) (disconnected from bus)
Feb 23 09:18:21 pop-os systemd[1816]: org.gnome.Shell@x11.service: Main process exited, code=dumped, status=6/ABRT
Feb 23 09:18:21 pop-os systemd[1816]: org.gnome.Shell@x11.service: Failed with result 'core-dump'.
Feb 23 09:18:21 pop-os systemd[1816]: org.gnome.Shell@x11.service: Consumed 7.332s CPU time.
Feb 23 09:18:21 pop-os systemd[1816]: org.gnome.Shell@x11.service: Scheduled restart job, restart counter is at 3.
Feb 23 09:18:21 pop-os systemd[1816]: Stopped GNOME Shell on X11.
Feb 23 09:18:21 pop-os systemd[1816]: org.gnome.Shell@x11.service: Consumed 7.332s CPU time.
Feb 23 09:18:21 pop-os systemd[1816]: Starting GNOME Shell on X11...
jacobgkau commented 2 years ago

GNOME Shell is no longer crashing when launching apps from the Launcher or Applications menu. Testing on oryp8, launching Steam in NVIDIA mode now works. Launching Steam in Hybrid mode also still works (launches on the dGPU as expected), as does launching in Integrated mode.