search

pop-os / gnome-shell

Pop!_OS fork of https://git.launchpad.net/~ubuntu-desktop/ubuntu/+source/gnome-shell
GNU General Public License v2.0
25 stars 4 forks source link

Add Pop!_Shop details #94

Closed 13r0ck closed 2 years ago

13r0ck commented 2 years ago

moved from pop-os/cosmic/extension.js because of changes in gnome 42

Requires pop-os/cosmic#325

jackpot51 commented 2 years ago

Are you sure this can't be done in an extension (pop-cosmic)?

13r0ck commented 2 years ago

@jackpot51 https://github.com/pop-os/gnome-shell/commit/1550976c51542c935471e54c5fba67eae36c6d09 seems to me like not really? At least it isn't possible like we had done in cosmic for 21.10.

This worked for me, but I can keep looking at putting it into cosmic if you would like

jackpot51 commented 2 years ago

Should be able to override the new function just like was being done before

13r0ck commented 2 years ago

~~@jackpot51 I can inject to replace _updateDetailsVisibility() so the Show Details button shows, but in cosmic how to I replace the value of ._detailsItem?~~

13r0ck commented 2 years ago

@jackpot51 even trying to inject a full constructor function to replace that value doesn't seem to work.

13r0ck commented 2 years ago

Never mind I found a solution in pop-os/cosmic#325