pop-os / gtk-theme

System76 Pop GTK+ Theme
GNU General Public License v3.0
782 stars 82 forks source link

suggestion #1 Buttons #158

Closed OliverScholtz closed 5 years ago

OliverScholtz commented 6 years ago

For considering, please try if you like ... I like it, for me it's a improvement:

**

button.image-button, actionbar > revealer > box .linked > button.image-button:not(.suggested-action):not(.destructive-action):not(.server-list-button), .titlebar:not(headerbar) .linked > button.image-button:not(.suggested-action):not(.destructive-action), headerbar .linked > button.image-button:not(.suggested-action):not(.destructive-action), .app-notification .linked > button.image-button, toolbar .linked > button.image-button, headerbar .linked.vertical > button.image-button:not(.suggested-action):not(.destructive-action), .app-notification .linked.vertical > button.image-button, toolbar .linked.vertical > button.image-button, .linked > button.flat.image-button, .linked.vertical > button.flat.image-button, .inline-toolbar button:not(.text-button), button.titlebutton, .raven .raven-header:not(.top) button.image-button, .raven .expander-button, .nautilus-window headerbar > revealer > button { border-radius: 4px; -gtk-outline-radius: 5px; }

button.minimize, button.maximize, button.close, button.circular { border-radius: 9999px; -gtk-outline-radius: 9999px; }

**

for gtk.css and gtk-dark.css

Thank you for considering and trying

I use Pop-slim Theme and this tweak make it more eye-candy.

isantop commented 6 years ago

I'm not seeing any differences when I apply this CSS within the inspector. Can you post a screenshot showing the differences?

OliverScholtz commented 6 years ago

captura de pantalla de 2018-05-07 18-56-27

It isn't round as you can see

OliverScholtz commented 6 years ago

captura de pantalla de 2018-05-07 18-52-34

my tweak ....

OliverScholtz commented 6 years ago

Put Geary, the Trash Icon is different with the rest buttons (hover) by default. After this change, it fits with the rest.


The only problem with my tweak is, that the message-box in Nautilus, the hover over the x-button isn't round anymore. But this can be corrected with putting the correct source in button.minimize, button.maximize, button.close, button.circular {

isantop commented 6 years ago

I don't think I like changing the image buttons to use square outlines instead of circles. It's one of the things that helps distinguish Pop from other themes.

OliverScholtz commented 6 years ago

then in Geary, for example, all hovers on buttons have to be round, too. You don't think?

isantop commented 6 years ago

That would be ideal. I'm not sure why Geary isn't setting all of those buttons to have the .image-button style class, but they should be. However, that's more of an issue with Geary than with the theme.

isantop commented 6 years ago

The v4 build of the theme will use rectangular button shapes for everything except .rounded buttons.

isantop commented 5 years ago

Fixed in master_cosmic