search

pop-os / gtk-theme

System76 Pop GTK+ Theme
GNU General Public License v3.0
787 stars 83 forks source link

Fix `render-assets` scripts to render assets #400

Closed isantop closed 5 years ago

isantop commented 5 years ago

Presently, our render-all-assets.sh scripts do not render all of the assets. There are external assets for the GTK2 theme as well as some assets that were flat-out missing from the source file. This PR updates the scripts to fix this issue, meaning that running render-all-assets.sh in any of the folders will correctly update all of the assets in that section.

Also included is a fresh pass of all of the assets, to ensure that all of them are up-to-date.

Fixes #386

@pop-os/quality-assurance For testing this, please ensure that you can use the gtk/src/{light,dark}/gtk-2.0/render-all-assets.sh scripts to render all of the GTK 2 assets. There should be 165 total assets rendered to both gtk/src/light/gtk-2.0/assets and gtk/src/dark/gtk-2.0/assets. Also check that the GTK3 assets render correctly in gtk/src/light/gtk-3.20/render-assets.sh. There should be 129 total assets in gtk/src/light/gtk-3.20/assets.

The GTK3 assets for both the light and dark themes are both stored in the light theme section; there isn't a light-dark split for GTK3 like there is for GTK2.

We should also check that this PR doesn't affect the build and that upgrades to the updated packages will not cause packaging system issues. The actual theme installed should be pretty much the same for both master_eoan and this PR.