search

pop-os / gtk-theme

System76 Pop GTK+ Theme
GNU General Public License v3.0
782 stars 81 forks source link

change accent color on text to pink #FE00A3 #466

Closed KyroSx closed 4 years ago

isantop commented 4 years ago

What's the rationale behind this change? As near as I can tell this will make all of the colors pink instead of blue, which does not match our branding guidelines.

KyroSx commented 4 years ago

What's the rationale behind this change? As near as I can tell this will make all of the colors pink instead of blue, which does not match our branding guidelines.

OMG I MESSED UP!!! I thought I was Pull requesting to my custom repository; I'm horrible with git :cry:

leviport commented 4 years ago

No worries lol, it happens

isantop commented 4 years ago

That's a GitHub issue, they automatically select upstream branches. I've done the exact same thing before on projects with Pop, actually!

KyroSx commented 4 years ago

That's a GitHub issue, they automatically select upstream branches. I've done the exact same thing before on projects with Pop, actually!

I enjoy the popOS theme, I also like a lot the Pink color, then I decided to try making my custom gtk-theme (was my first attempt). So after I made the changes, commit, then PR, but I don't know what has happened. I was confused.

Bad luck :four_leaf_clover: .