pop-os / gtk-theme

System76 Pop GTK+ Theme
GNU General Public License v3.0
781 stars 80 forks source link

Transparent Background on Drop Down in GNUCash #467

Closed ardichoke closed 3 years ago

ardichoke commented 3 years ago

Describe the problem: The account selection drop-down menus in GNUCash have a transparent background when using Pop OS themes (both dark and light), this makes the text illegible. Interestingly, if you change focus to another window while these drop-downs are open, the background on them becomes solid as expected.

Screenshot from 2020-08-13 10-56-20 Screenshot from 2020-08-13 10-56-32

Steps to reproduce:

  1. With a Pop OS theme applied, launch GNUCash
  2. Open an account
  3. Click on the "Transfer" drop-down in the ledger

Distribution:

PRETTY_NAME="Pop!_OS 20.04 LTS"

Pop version:


[502]$ apt policy pop-gtk-theme | grep -i installed

WARNING: apt does not have a stable CLI interface. Use with caution in scripts.

  Installed: 5.2.0~1593549084~20.04~8c31be9

[503]$     flatpak info org.gtk.Gtk3theme.Pop
error: org.gtk.Gtk3theme.Pop/*unspecified*/*unspecified* not installed
isantop commented 3 years ago

What kind of result do you get if you use GNUCash with the Adwaita theme? You can temporarily run it with the Adwaita theme using this command:

GTK_THEME=Adwaita gnucash

ardichoke commented 3 years ago

It works as expected, with a non-transparent background and readable text even when GNUCash has focus. I actually switched my theme over to Adwaita entirely because of this bug, since I spend a non-trivial amount of time using GNUCash and this bug makes it very hard to work with.

isantop commented 3 years ago

Thanks for checking that! That helps a lot in figuring out where the issue is being caused. I've got a new commit ready to go which will be released soon which fixes this issue.

indrekots commented 3 years ago

I seem to be having a similar issue, but for me, I'm experiencing transparent dropdowns only while using Pop OS dark theme. The transparency issue does not occur when using the light theme.

$ apt policy pop-gtk-theme
pop-gtk-theme:
  Installed: 5.3.0~1605227705~20.10~50f789b

The following image depicts the dark theme. Screenshot from 2020-11-19 22-48-54

Similar to what @ardichoke reported, when the GnuCash window loses focus, the dropdown becomes readable, although it's not fully opaque. Screenshot from 2020-11-19 22-49-12

When switching the theme to Pop OS light, then I don't see any issues. Screenshot from 2020-11-19 22-50-01

Anything else I could provide to help debug the issue?

jacobgkau commented 3 years ago

Interesting. I am not seeing the same issue with the same version of the theme installed:

gnucash-working

@indrekots We would probably need to figure out what's different between your machine and other machines to cause this. If you create a new user account (Settings -> Users), log out of your normal account and into the new account, and open GNUCash, does the issue occur there?

indrekots commented 3 years ago

With a brand new user, I didn't observe this issue. Perhaps it could be due to some plugin? I'll try to disable them and report back.

indrekots commented 3 years ago

Not sure what has changed on my computer but now It works as intended. Therefore, disregard my comments.

bdelespierre commented 2 years ago

I experience the same behavior. I believe this is due to upgrading GTK and still using a relatively old .gnucash savefile. The problem doesn't seem to appear on new savefiles.