search

pop-os / gtk-theme

System76 Pop GTK+ Theme
GNU General Public License v3.0
781 stars 80 forks source link

Build error when generating debian package with pbuilder #468

Closed kgilmer closed 3 years ago

kgilmer commented 3 years ago

Describe the problem: When trying to build a debian package from the source unchanged, I get the following error from pbuilder:

$ sudo pbuilder --build --distribution focal ../pop-gtk-theme_5.2.0.dsc
...
gtk/src/light/gtk-3.20/meson.build:157:2: ERROR: Tried to create target "light-gtk-3.20-gtk-dark-generated.css", but a target of that name already exists.
dh_auto_configure: cd obj-x86_64-linux-gnu && LC_ALL=C.UTF-8 meson .. --wrap-mode=nodownload --buildtype=plain --prefix=/usr --sysconfdir=/etc --localstatedir=/var --libdir=lib/x86_64-linux-gnu --libexecdir=lib/x86_64-linux-gnu -Dgnome-shell-gresource=true returned exit code 1
debian/rules:8: recipe for target 'override_dh_auto_configure' failed
...

Steps to reproduce:

$ git clone https://github.com/pop-os/gtk-theme.git
$ cd gtk-theme
$ dch # add temp changelog entry to avoid key signing problem
$ debuild -S -sa
$ sudo pbuilder --build --distribution focal ../pop-gtk-theme_5.2.0.dsc

Distribution: Ubuntu 20.04.1 LTS

Pop version: N/A

isantop commented 3 years ago

I can't seem to replicate this with a fresh Ubuntu 20.04 install.

Commands run:

sudo apt install git pbuilder ${shlibs:Depends} ${misc:Depends} gnome-themes-extra gtk2-engines-pixbuf gtk2-engines-murrine
git clone https://github.com/pop-os/gtk-theme.git
cd gtk-theme
sudo pbuilder create --distribution focal
debuild -S -sa # NOTE: A GPG key was created in Passwords and Keys for the purposes of testing this issue
sudo pbuilder --build --distribution focal ../pop-gtk-theme_5.2.0.dsc

All of these commands exited successfully.

hmoffatt commented 3 years ago

I also have this problem on Debian buster. I checked out the source, and when I run meson build I get:

$ meson build
The Meson build system
Version: 0.49.2
Source dir: /home/hamish/src/pop-theme/gtk-theme
Build dir: /home/hamish/src/pop-theme/gtk-theme/build
Build type: native build
Project name: Pop
Project version: 5.0.0
Build machine cpu family: x86_64
Build machine cpu: x86_64
Program gresources-xml-parser.py found: YES (/home/hamish/src/pop-theme/gtk-theme/gnome-shell/gresources-xml-parser.py)
Program copy-and-rename.py found: YES (/home/hamish/src/pop-theme/gtk-theme/gnome-shell/copy-and-rename.py)
Program sassc found: YES (/usr/bin/sassc)
Configuring gnome-shell.scss using configuration
Program install-switcher-themes.sh found: YES (/home/hamish/src/pop-theme/gtk-theme/gnome-shell/src/install-switcher-themes.sh)
Configuring gnome-shell-dark.scss using configuration
Program install-shell.sh found: YES (/home/hamish/src/pop-theme/gtk-theme/gnome-shell/src/install-shell.sh)
Configuring index.theme using configuration
Program sassc found: YES (/usr/bin/sassc)
Configuring gtk.gresource.xml using configuration
Found pkg-config: /usr/bin/pkg-config (0.29)
Program sassc found: YES (/usr/bin/sassc)

gtk/src/light/gtk-3.20/meson.build:157:2: ERROR:  Tried to create target "light-gtk-3.20-gtk-dark-generated.css", but a target of that name already exists.

A full log can be found at /home/hamish/src/pop-theme/gtk-theme/build/meson-logs/meson-log.txt

There's nothing extra in the log; it just ends with

gtk/src/light/gtk-3.20/meson.build:157:2: ERROR: Tried to create target "light-gtk-3.20-gtk-dark-generated.css", but a target of that name already exists.

with no other errors obvious.

charmcity-code commented 3 years ago

the same thing happens to me with Debian buster

hmoffatt commented 3 years ago

I built it in a Debian sid chroot succesfully. The resulting package installs ok on buster.

isantop commented 3 years ago

I believe the latest changes to the theme have fixed this issue as there are now no longer duplicate targets being built (the symlink situation is removed. Please feel free to re-open this if the issue is still present, and include a build log.