search

pop-os / gtk-theme

System76 Pop GTK+ Theme
GNU General Public License v3.0
787 stars 83 forks source link

Background of Lists changed into light gray instead of normal white (For example, files in list view) #475

Closed TechnologyMan101 closed 4 years ago

TechnologyMan101 commented 4 years ago

Describe the problem: The background color of lists has changed to a light gray. It used to be white. Dark theme has a similar effect

Current (Light): Screenshot from 2020-10-11 20-43-27

Screenshot from 2020-10-12 00-16-28

Previous (Light): Screenshot from 2020-10-12 07-19-16

Screenshot from 2020-10-12 07-19-24

Current (Dark): Screenshot from 2020-10-12 00-24-16

Screenshot from 2020-10-12 00-24-36

Previous (Dark): Screenshot from 2020-10-12 07-18-52

Screenshot from 2020-10-12 07-18-43

Steps to reproduce:

  1. Open Files
  2. Change into List view
  3. Results

Distribution: PRETTY_NAME="Pop!_OS 20.04 LTS"

Pop version: Installed: 5.2.0~1599689740~20.04~11b9d22

jacobgkau commented 4 years ago

Confirmed this was a side effect of https://github.com/pop-os/gtk-theme/pull/470. treeview.view used to have a transparent background, now it uses $bg_color as its background color.

I ideally would have noticed this while testing that PR, but after taking screenshots to compare, it looks like the new background color matches what other two-pane apps use for the main content section:

gtk-theme-i475-screenshot1

gtk-theme-i475-screenshot2

Although it is a bit inconsistent that the same color isn't used for the "Other Locations" page or icon view. In the case of the "Language Support" window, it seems like it makes sense for the list to be separated out from the rest of the tab with a different color, since the cursor needs to be inside of the list to scroll.

TechnologyMan101 commented 4 years ago

So, would this be considered a non-issue or does this need fixing?

isantop commented 4 years ago

This is a bug, and the treeivews should have their background color set to base_color instead of bg-color. That should preserve the fix introduced with #470 without making the treeviews look weird.

TechnologyMan101 commented 4 years ago

Saw that this got fixed. Will close this issue now.